Skip to content

Commit 746c1fe

Browse files
committed
More cleanup
1 parent 4f48198 commit 746c1fe

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Objects/perf_trampoline.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,23 +86,23 @@ compile_trampoline(void)
8686
FILE *
8787
perf_map_open(pid_t pid)
8888
{
89-
char filename[500];
89+
char filename[100];
9090
snprintf(filename, sizeof(filename), "/tmp/perf-%d.map", pid);
9191
FILE *res = fopen(filename, "a");
9292
if (!res) {
93-
fprintf(stderr, "Couldn't open %s: errno(%d)", filename, errno);
94-
exit(0);
93+
_Py_FatalErrorFormat(__func__, "Couldn't open %s: errno(%d)", filename, errno);
94+
return NULL;
9595
}
9696
return res;
9797
}
9898

9999
int
100100
perf_map_close(FILE *fp)
101101
{
102-
if (fp)
102+
if (fp) {
103103
return fclose(fp);
104-
else
105-
return 0;
104+
}
105+
return 0;
106106
}
107107

108108
void
@@ -130,6 +130,9 @@ py_trampoline_evaluator(PyThreadState *ts, _PyInterpreterFrame *frame,
130130
return NULL;
131131
}
132132
FILE *pfile = perf_map_open(getpid());
133+
if (pfile == NULL) {
134+
return NULL;
135+
}
133136
perf_map_write_entry(pfile, new_trampoline, code_arena.code_size,
134137
PyUnicode_AsUTF8(co->co_qualname),
135138
PyUnicode_AsUTF8(co->co_filename));

0 commit comments

Comments
 (0)