You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
from Barry Warsaw:
- It's possible the code jumps to error: after pkgname is decref'd. I
think that decref should be deferred until just before the good-path
return.
- pkgname_or_unknown will be a new reference if pkgname is NULL, or it
will steal the pkgname reference if it's not. In either case, the error
stanza should decref pkgname_or_unknown, which will take care of
ensuring the object gets decref for any goto error path.
- pkgpath doesn't get decref'd. I think you should Py_XDECREF it before
the return NULL just in case pkgpath is itself NULL.
0 commit comments