Skip to content

Commit 5ae6c6d

Browse files
authored
gh-109566: regrtest --fast-ci no longer enables --nowindows (#110121)
The --nowindows option is deprecated and does nothing but logs a warning.
1 parent 9c91141 commit 5ae6c6d

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

Lib/test/libregrtest/cmdline.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import sys
55
from test.support import os_helper
66

7-
from .utils import MS_WINDOWS
8-
97

108
USAGE = """\
119
python -m test [options] [test_name1 [test_name2 ...]]
@@ -414,7 +412,7 @@ def _parse_args(args, **kwargs):
414412
# Similar to options:
415413
#
416414
# -j0 --randomize --fail-env-changed --fail-rerun --rerun
417-
# --slowest --verbose3 --nowindows
415+
# --slowest --verbose3
418416
if ns.use_mp is None:
419417
ns.use_mp = 0
420418
ns.randomize = True
@@ -424,8 +422,6 @@ def _parse_args(args, **kwargs):
424422
ns.rerun = True
425423
ns.print_slow = True
426424
ns.verbose3 = True
427-
if MS_WINDOWS:
428-
ns.nowindows = True # Silence alerts under Windows
429425
else:
430426
ns._add_python_opts = False
431427

Lib/test/test_regrtest.py

-2
Original file line numberDiff line numberDiff line change
@@ -376,8 +376,6 @@ def test_unknown_option(self):
376376

377377
def check_ci_mode(self, args, use_resources, rerun=True):
378378
ns = cmdline._parse_args(args)
379-
if utils.MS_WINDOWS:
380-
self.assertTrue(ns.nowindows)
381379

382380
# Check Regrtest attributes which are more reliable than Namespace
383381
# which has an unclear API

0 commit comments

Comments
 (0)