Skip to content

Commit 4f1440f

Browse files
authored
[3.13] gh-126451: Revert backports of ABC registrations for contextvars.Context and multiprocessing proxies (#126734)
1 parent efd8fe4 commit 4f1440f

7 files changed

+0
-36
lines changed

Lib/contextvars.py

-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
import _collections_abc
21
from _contextvars import Context, ContextVar, Token, copy_context
32

43

54
__all__ = ('Context', 'ContextVar', 'Token', 'copy_context')
6-
7-
8-
_collections_abc.Mapping.register(Context)

Lib/multiprocessing/managers.py

-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import threading
1919
import signal
2020
import array
21-
import collections.abc
2221
import queue
2322
import time
2423
import types
@@ -1168,7 +1167,6 @@ def __imul__(self, value):
11681167

11691168
__class_getitem__ = classmethod(types.GenericAlias)
11701169

1171-
collections.abc.MutableSequence.register(BaseListProxy)
11721170

11731171
_BaseDictProxy = MakeProxyType('DictProxy', (
11741172
'__contains__', '__delitem__', '__getitem__', '__iter__', '__len__',
@@ -1181,7 +1179,6 @@ def __imul__(self, value):
11811179
class DictProxy(_BaseDictProxy):
11821180
__class_getitem__ = classmethod(types.GenericAlias)
11831181

1184-
collections.abc.MutableMapping.register(_BaseDictProxy)
11851182

11861183
ArrayProxy = MakeProxyType('ArrayProxy', (
11871184
'__len__', '__getitem__', '__setitem__'

Lib/test/_test_multiprocessing.py

-9
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import functools
1818
import signal
1919
import array
20-
import collections.abc
2120
import socket
2221
import random
2322
import logging
@@ -2460,10 +2459,6 @@ def test_list(self):
24602459
a.append('hello')
24612460
self.assertEqual(f[0][:], [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 'hello'])
24622461

2463-
def test_list_isinstance(self):
2464-
a = self.list()
2465-
self.assertIsInstance(a, collections.abc.MutableSequence)
2466-
24672462
def test_list_iter(self):
24682463
a = self.list(list(range(10)))
24692464
it = iter(a)
@@ -2504,10 +2499,6 @@ def test_dict(self):
25042499
self.assertEqual(sorted(d.values()), [chr(i) for i in indices])
25052500
self.assertEqual(sorted(d.items()), [(i, chr(i)) for i in indices])
25062501

2507-
def test_dict_isinstance(self):
2508-
a = self.dict()
2509-
self.assertIsInstance(a, collections.abc.MutableMapping)
2510-
25112502
def test_dict_iter(self):
25122503
d = self.dict()
25132504
indices = list(range(65, 70))

Lib/test/test_context.py

-14
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import collections.abc
21
import concurrent.futures
32
import contextvars
43
import functools
@@ -343,19 +342,6 @@ def ctx2_fun():
343342

344343
ctx1.run(ctx1_fun)
345344

346-
def test_context_isinstance(self):
347-
ctx = contextvars.Context()
348-
self.assertIsInstance(ctx, collections.abc.Mapping)
349-
self.assertTrue(issubclass(contextvars.Context, collections.abc.Mapping))
350-
351-
mapping_methods = (
352-
'__contains__', '__eq__', '__getitem__', '__iter__', '__len__',
353-
'__ne__', 'get', 'items', 'keys', 'values',
354-
)
355-
for name in mapping_methods:
356-
with self.subTest(name=name):
357-
self.assertTrue(callable(getattr(ctx, name)))
358-
359345
@isolated_context
360346
@threading_helper.requires_working_threading()
361347
def test_context_threads_1(self):

Misc/ACKS

-1
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,6 @@ Emily Morehouse
12701270
Derek Morr
12711271
James A Morrison
12721272
Martin Morrison
1273-
Stephen Morton
12741273
Derek McTavish Mounce
12751274
Alessandro Moura
12761275
Pablo Mouzo

Misc/NEWS.d/next/Library/2024-11-04-16-40-02.gh-issue-126417.OWPqn0.rst

-3
This file was deleted.

Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.XJMtqz.rst

-2
This file was deleted.

0 commit comments

Comments
 (0)