Skip to content

Commit 3d49b34

Browse files
committed
gh-127146: Fix Emscripten test suite when run with -uall
Emscripten large file support works fine and is required for `testZip64LargeFile` to work. And skip more stack overflows
1 parent 04bc681 commit 3d49b34

File tree

7 files changed

+6
-12
lines changed

7 files changed

+6
-12
lines changed

Lib/test/test_builtin.py

+1
Original file line numberDiff line numberDiff line change
@@ -1104,6 +1104,7 @@ def test_filter_pickle(self):
11041104
self.check_iter_pickle(f1, list(f2), proto)
11051105

11061106
@support.skip_wasi_stack_overflow()
1107+
@support.skip_emscripten_stack_overflow()
11071108
@support.requires_resource('cpu')
11081109
def test_filter_dealloc(self):
11091110
# Tests recursive deallocation of nested filter objects using the

Lib/test/test_capi/test_misc.py

+2
Original file line numberDiff line numberDiff line change
@@ -411,10 +411,12 @@ def test_trashcan_subclass(self):
411411
for i in range(100):
412412
L = MyList((L,))
413413

414+
@support.skip_emscripten_stack_overflow()
414415
@support.requires_resource('cpu')
415416
def test_trashcan_python_class1(self):
416417
self.do_test_trashcan_python_class(list)
417418

419+
@support.skip_emscripten_stack_overflow()
418420
@support.requires_resource('cpu')
419421
def test_trashcan_python_class2(self):
420422
from _testcapi import MyList

Lib/test/test_descr.py

+1
Original file line numberDiff line numberDiff line change
@@ -4519,6 +4519,7 @@ class Oops(object):
45194519
o.whatever = Provoker(o)
45204520
del o
45214521

4522+
@support.skip_emscripten_stack_overflow()
45224523
@support.skip_wasi_stack_overflow()
45234524
@support.requires_resource('cpu')
45244525
def test_wrapper_segfault(self):

Lib/test/test_exceptions.py

+1
Original file line numberDiff line numberDiff line change
@@ -1428,6 +1428,7 @@ def g():
14281428
self.assertIsInstance(exc, RecursionError, type(exc))
14291429
self.assertIn("maximum recursion depth exceeded", str(exc))
14301430

1431+
@support.skip_emscripten_stack_overflow()
14311432
@support.skip_wasi_stack_overflow()
14321433
@cpython_only
14331434
@support.requires_resource('cpu')

Lib/test/test_io.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ def do_test(test, obj, abilities):
553553
for [test, abilities] in tests:
554554
with self.subTest(test):
555555
if test == pipe_writer and not threading_helper.can_start_thread:
556-
skipTest()
556+
self.skipTest("Requires threading but threading not supported")
557557
with test() as obj:
558558
do_test(test, obj, abilities)
559559

configure

-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

-4
Original file line numberDiff line numberDiff line change
@@ -3158,10 +3158,6 @@ if test "$ac_cv_sizeof_off_t" -gt "$ac_cv_sizeof_long" -a \
31583158
else
31593159
have_largefile_support="no"
31603160
fi
3161-
dnl LFS does not work with Emscripten 3.1
3162-
AS_CASE([$ac_sys_system],
3163-
[Emscripten], [have_largefile_support="no"]
3164-
)
31653161
AS_VAR_IF([have_largefile_support], [yes], [
31663162
AC_DEFINE([HAVE_LARGEFILE_SUPPORT], [1],
31673163
[Defined to enable large file support when an off_t is bigger than a long

0 commit comments

Comments
 (0)