Skip to content

Commit 381f3e4

Browse files
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037)
(cherry picked from commit ec31653) Co-authored-by: Dong-hee Na <[email protected]>
1 parent 82f24ff commit 381f3e4

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

Lib/test/test_nntplib.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def _check_desc(desc):
8282
desc = self.server.description(self.GROUP_NAME)
8383
_check_desc(desc)
8484
# Another sanity check
85-
self.assertIn("Python", desc)
85+
self.assertIn(self.DESC, desc)
8686
# With a pattern
8787
desc = self.server.description(self.GROUP_PAT)
8888
_check_desc(desc)
@@ -299,6 +299,7 @@ class NetworkedNNTPTests(NetworkedNNTPTestsMixin, unittest.TestCase):
299299
NNTP_HOST = 'news.trigofacile.com'
300300
GROUP_NAME = 'fr.comp.lang.python'
301301
GROUP_PAT = 'fr.comp.lang.*'
302+
DESC = 'Python'
302303

303304
NNTP_CLASS = NNTP
304305

@@ -332,8 +333,11 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
332333
# 400 connections per day are accepted from each IP address."
333334

334335
NNTP_HOST = 'nntp.aioe.org'
335-
GROUP_NAME = 'comp.lang.python'
336-
GROUP_PAT = 'comp.lang.*'
336+
# bpo-42794: aioe.test is one of the official groups on this server
337+
# used for testing: https://news.aioe.org/manual/aioe-hierarchy/
338+
GROUP_NAME = 'aioe.test'
339+
GROUP_PAT = 'aioe.*'
340+
DESC = 'test'
337341

338342
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)
339343

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Update test_nntplib to use offical group name of news.aioe.org for testing.
2+
Patch by Dong-hee Na.

0 commit comments

Comments
 (0)