bpo-36672: Fix a compiler warning in winreg.SetValue() (GH-12882)

miss-islington · ZackerySpytz · web-flow · commit 36aecc0079af · 2019-04-22T10:31:46.000-07:00
(cherry picked from commit 34366b7) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
diff --git a/PC/winreg.c b/PC/winreg.c
@@ -1609,7 +1609,7 @@ winreg_SetValue_impl(PyObject *module, HKEY key, const Py_UNICODE *sub_key,
     }
 
     Py_BEGIN_ALLOW_THREADS
-    rc = RegSetValueW(key, sub_key, REG_SZ, value, value_length+1);
+    rc = RegSetValueW(key, sub_key, REG_SZ, value, (DWORD)(value_length + 1));
     Py_END_ALLOW_THREADS
     if (rc != ERROR_SUCCESS)
         return PyErr_SetFromWindowsErrWithFunction(rc, "RegSetValue");

Original file line number	Diff line number	Diff line change
`@@ -1609,7 +1609,7 @@ winreg_SetValue_impl(PyObject module, HKEY key, const Py_UNICODE sub_key,`
`1609`	`1609`	`}`
`1610`	`1610`
`1611`	`1611`	`Py_BEGIN_ALLOW_THREADS`
`1612`		`- rc = RegSetValueW(key, sub_key, REG_SZ, value, value_length+1);`
	`1612`	`+ rc = RegSetValueW(key, sub_key, REG_SZ, value, (DWORD)(value_length + 1));`
`1613`	`1613`	`Py_END_ALLOW_THREADS`
`1614`	`1614`	`if (rc != ERROR_SUCCESS)`
`1615`	`1615`	`return PyErr_SetFromWindowsErrWithFunction(rc, "RegSetValue");`