gh-131762: Fixed dereferencing the pointer 'parser_token->metadata' with a NULL value (#131764)

rialbat · web-flow · commit 2c686a9ac243 · 2025-03-26T18:44:56.000Z
diff --git a/Parser/pegen.c b/Parser/pegen.c
@@ -194,7 +194,7 @@ initialize_token(Parser *p, Token *parser_token, struct token *new_token, int to
     parser_token->metadata = NULL;
     if (new_token->metadata != NULL) {
         if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {
-            Py_DECREF(parser_token->metadata);
+            Py_DECREF(new_token->metadata);
             return -1;
         }
         parser_token->metadata = new_token->metadata;

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ initialize_token(Parser p, Token parser_token, struct token *new_token, int to`
`194`	`194`	`parser_token->metadata = NULL;`
`195`	`195`	`if (new_token->metadata != NULL) {`
`196`	`196`	`if (_PyArena_AddPyObject(p->arena, new_token->metadata) < 0) {`
`197`		`- Py_DECREF(parser_token->metadata);`
	`197`	`+ Py_DECREF(new_token->metadata);`
`198`	`198`	`return -1;`
`199`	`199`	`}`
`200`	`200`	`parser_token->metadata = new_token->metadata;`