Skip to content

Commit 21cd0bd

Browse files
committed
bpo-37399: Extend the tests with some whitespace to see if merging text/tail content works as expected.
1 parent fb438a2 commit 21cd0bd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

Lib/test/test_xml_etree.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -2984,35 +2984,35 @@ def test_late_tail_mix_pi_comments(self):
29842984
class TreeBuilderSubclass(ET.TreeBuilder):
29852985
pass
29862986

2987-
xml = "<a>text<?pi1?><!-- comment --><?pi2?>tail</a>"
2987+
xml = "<a>text<?pi1?> <!-- comment -->\n<?pi2?>tail</a>"
29882988
parser = ET.XMLParser(target=ET.TreeBuilder(insert_comments=True))
29892989
parser.feed(xml)
29902990
a = parser.close()
29912991
self.assertEqual(a[0].text, ' comment ')
2992-
self.assertEqual(a[0].tail, 'tail')
2993-
self.assertEqual(a.text, "text")
2992+
self.assertEqual(a[0].tail, '\ntail')
2993+
self.assertEqual(a.text, "text ")
29942994

29952995
parser = ET.XMLParser(target=TreeBuilderSubclass(insert_comments=True))
29962996
parser.feed(xml)
29972997
a = parser.close()
29982998
self.assertEqual(a[0].text, ' comment ')
2999-
self.assertEqual(a[0].tail, 'tail')
3000-
self.assertEqual(a.text, "text")
2999+
self.assertEqual(a[0].tail, '\ntail')
3000+
self.assertEqual(a.text, "text ")
30013001

3002-
xml = "<a>text<!-- comment --><?pi data?>tail</a>"
3002+
xml = "<a>text<!-- comment -->\n<?pi data?>tail</a>"
30033003
parser = ET.XMLParser(target=ET.TreeBuilder(insert_pis=True))
30043004
parser.feed(xml)
30053005
a = parser.close()
30063006
self.assertEqual(a[0].text, 'pi data')
30073007
self.assertEqual(a[0].tail, 'tail')
3008-
self.assertEqual(a.text, "text")
3008+
self.assertEqual(a.text, "text\n")
30093009

30103010
parser = ET.XMLParser(target=TreeBuilderSubclass(insert_pis=True))
30113011
parser.feed(xml)
30123012
a = parser.close()
30133013
self.assertEqual(a[0].text, 'pi data')
30143014
self.assertEqual(a[0].tail, 'tail')
3015-
self.assertEqual(a.text, "text")
3015+
self.assertEqual(a.text, "text\n")
30163016

30173017
def test_treebuilder_elementfactory_none(self):
30183018
parser = ET.XMLParser(target=ET.TreeBuilder(element_factory=None))

0 commit comments

Comments
 (0)