Skip to content

Commit 13c79c6

Browse files
authored
bpo-33901: Fix test_dbm_gnu for gdbm 1.15 (GH-7798)
Fix test_dbm_gnu.test_reorganize() on macOS with gdbm 1.15: add a larger value to make sure that the file size changes.
1 parent 2edcf0a commit 13c79c6

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Lib/test/test_dbm_gnu.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,22 @@ def test_reorganize(self):
7272
self.g = gdbm.open(filename, 'c')
7373
size0 = os.path.getsize(filename)
7474

75-
self.g['x'] = 'x' * 10000
75+
# bpo-33901: on macOS with gdbm 1.15, an empty database uses 16 MiB
76+
# and adding an entry of 10,000 B has no effect on the file size.
77+
# Add size0 bytes to make sure that the file size changes.
78+
value_size = max(size0, 10000)
79+
self.g['x'] = 'x' * value_size
7680
size1 = os.path.getsize(filename)
77-
self.assertTrue(size0 < size1)
81+
self.assertGreater(size1, size0)
7882

7983
del self.g['x']
8084
# 'size' is supposed to be the same even after deleting an entry.
8185
self.assertEqual(os.path.getsize(filename), size1)
8286

8387
self.g.reorganize()
8488
size2 = os.path.getsize(filename)
85-
self.assertTrue(size1 > size2 >= size0)
89+
self.assertLess(size2, size1)
90+
self.assertGreaterEqual(size2, size0)
8691

8792
def test_context_manager(self):
8893
with gdbm.open(filename, 'c') as db:
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Fix test_dbm_gnu on macOS with gdbm 1.15: add a larger value to make sure that
2+
the file size changes.

0 commit comments

Comments
 (0)