A stray JUMP_BACKWARD also ends the trace

gvanrossum · gvanrossum · commit 0f21e09949e3 · 2023-07-06T16:27:18.000-07:00
diff --git a/Python/optimizer.c b/Python/optimizer.c
@@ -382,9 +382,11 @@ translate_bytecode_to_trace(
                     && trace_length + 3 <= max_length)
                 {
                     ADD_TO_TRACE(JUMP_TO_TOP, 0);
-                    goto done;
                 }
-                // Else fall through!
+                else {
+                    DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");
+                }
+                goto done;
             }
             default:
             {

Original file line number	Diff line number	Diff line change
`@@ -382,9 +382,11 @@ translate_bytecode_to_trace(`
`382`	`382`	`&& trace_length + 3 <= max_length)`
`383`	`383`	`{`
`384`	`384`	`ADD_TO_TRACE(JUMP_TO_TOP, 0);`
`385`		`- goto done;`
`386`	`385`	`}`
`387`		`- // Else fall through!`
	`386`	`+ else {`
	`387`	`+ DPRINTF(2, "JUMP_BACKWARD not to top ends trace\n");`
	`388`	`+ }`
	`389`	`+ goto done;`
`388`	`390`	`}`
`389`	`391`	`default:`
`390`	`392`	`{`