Skip to content

Ubuntu job should install gdb #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner opened this issue Oct 30, 2020 · 3 comments
Closed

Ubuntu job should install gdb #383

vstinner opened this issue Oct 30, 2020 · 3 comments

Comments

@vstinner
Copy link
Member

test_gdb is skipped on the GitHub Action Ubuntu job, because gdb is not installed.

Would it be possible to install it?

I broke buildbots because I renamed the function "collect" to "gc_collect_main" in Modules/gcmodule.c and python-gdb.py uses it to check if Python is running a garbage collection. The strange thing is that test_gdb passed on Travis CI of my PR python/cpython#23038 test_gdb was skipped on the Ubuntu job.

@brettcannon
Copy link
Member

You can install whatever you want as you have full access to the running container through passwordless sudo. Add a step to install gdb (and anything else you want) to the appropriate job and that should do it.

@vstinner
Copy link
Member Author

I created python/cpython#23043 to add gdb dependency. Let's see if test_gdb is still skipped or nor.

@vstinner
Copy link
Member Author

Fixed in 3.9 and master, 3.8 is going to be fixed as soon as the CI tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants