From c917e8d421fb35e08ff9ac4b91c17457ac41202d Mon Sep 17 00:00:00 2001 From: Philippe F Date: Sun, 15 Aug 2021 09:00:56 +0200 Subject: [PATCH 1/5] allow ci to run on all branches --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d2c4a131..5afe9c9c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: push: branches: - - master + - "*" tags: - v* pull_request: From 864b6ea67ab3b3813b4fb4d06d3a5d94dda06ecf Mon Sep 17 00:00:00 2001 From: Philippe F Date: Sun, 14 Nov 2021 21:25:38 +0100 Subject: [PATCH 2/5] Enable CI, only on master --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5afe9c9c..6e70acf7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: push: branches: - - "*" + - master tags: - v* pull_request: @@ -13,7 +13,7 @@ on: schedule: # Daily at 06:14. This is just an arbitrary time to stagger # relative to other daily builds in any given organization. - # - cron: '14 6 * * *' + - cron: '14 6 * * *' jobs: test: From aa59307a32b7984dfc0f2fb92d21ef4659f057d9 Mon Sep 17 00:00:00 2001 From: Philippe F Date: Mon, 15 Nov 2021 09:45:34 +0100 Subject: [PATCH 3/5] Do not schedule CI every night --- .github/workflows/ci.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6e70acf7..703272a7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,10 +10,6 @@ on: pull_request: branches: - "*" - schedule: - # Daily at 06:14. This is just an arbitrary time to stagger - # relative to other daily builds in any given organization. - - cron: '14 6 * * *' jobs: test: From cc125da629f62609eb9f1a75b710a28c5f45c64e Mon Sep 17 00:00:00 2001 From: Philippe F Date: Mon, 15 Nov 2021 17:45:13 +0100 Subject: [PATCH 4/5] Enable CI on windows branch --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 703272a7..cc3518fb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,6 +5,7 @@ on: push: branches: - master + - run-ci-on-windows tags: - v* pull_request: From a6042b9dd42fc152c96ae9c8a09fcd2b9709e9f4 Mon Sep 17 00:00:00 2001 From: Philippe F Date: Sun, 23 Jul 2023 11:38:03 +0200 Subject: [PATCH 5/5] Add test for recently added stub QWebEngineView.setPage(None) --- tests/qwebengineview.py | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 tests/qwebengineview.py diff --git a/tests/qwebengineview.py b/tests/qwebengineview.py new file mode 100644 index 00000000..6e0cfada --- /dev/null +++ b/tests/qwebengineview.py @@ -0,0 +1,7 @@ +from PyQt5.QtWebEngineWidgets import QWebEngineView + +view = QWebEngineView() +view.setPage(None) + +# note: eventhough the page set is None, Qt will create a default page if you +# retrieve it with page()