Skip to content

Bug in version 0.13.3 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarangsbabu367 opened this issue Mar 13, 2020 · 9 comments
Closed

Bug in version 0.13.3 #219

sarangsbabu367 opened this issue Mar 13, 2020 · 9 comments

Comments

@sarangsbabu367
Copy link

7e920f8#r37808923

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 13, 2020

Hi @sarangsbabu367

thanks for reporting the bug.

Request should have path dict

Can you give me more details? Example?

@sarangsbabu367
Copy link
Author

@p1c2u
image
The problem is in the line which i mentioned above. openapi_core is trying to get path by request.parameters.path but path is a key.
image

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 16, 2020

Okay but how your request object look like? How you create request object? Which integration you use?

@sarangsbabu367
Copy link
Author

I am integrating with starlette.

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 16, 2020

The library has no integration with starlette 🤔 You should file a bug to author of the integration library.

@sarangsbabu367
Copy link
Author

sarangsbabu367 commented Mar 18, 2020

image

I am using openapi_core like this, this works fine with openapi_core version 0.13.2 but got the above exception in version 0.13.3, my request look like this,

image
@p1c2u

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 23, 2020

@sarangsbabu367
You use StarletteOpenAPIRequest which is not part of the library and the problem must be inside the class.

@sarangsbabu367
Copy link
Author

@p1c2u Can you please explain how openapi-core wants the request, Previusly i was giving headers, cookies, path, queries as a dictionary inside parameters. Now it is not working, the probem is when i changed this to a namedtuple instead of dictionay, I am getting a error cant set attribute
image

Line 39 is causing the problem, is it an issue in my side ??

@sarangsbabu367
Copy link
Author

Issue was with my request structure to openapi_core, when i changed to the format OpenAPIRequest. issue was solved, sorry for wasting your time @p1c2u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants