Skip to content

Commit adee10f

Browse files
committed
back to {} for metadata default
1 parent 0a5456a commit adee10f

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

src/desert/__init__.py

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def field(
7070
marshmallow_field: marshmallow.fields.Field,
7171
*,
7272
default: T,
73-
metadata: t.Optional[t.Mapping[object, object]] = None,
73+
metadata: t.Mapping[object, object] = {},
7474
**kw: object,
7575
) -> T:
7676
...
@@ -81,7 +81,7 @@ def field(
8181
marshmallow_field: marshmallow.fields.Field,
8282
*,
8383
default_factory: t.Callable[[], T],
84-
metadata: t.Optional[t.Mapping[object, object]] = None,
84+
metadata: t.Mapping[object, object] = {},
8585
**kw: object,
8686
) -> T:
8787
...
@@ -91,7 +91,7 @@ def field(
9191
def field(
9292
marshmallow_field: marshmallow.fields.Field,
9393
*,
94-
metadata: t.Optional[t.Mapping[object, object]] = None,
94+
metadata: t.Mapping[object, object] = {},
9595
**kw: object,
9696
) -> object:
9797
...
@@ -103,7 +103,7 @@ def field(
103103
# plugin that indicates the actual type.
104104
def field(
105105
marshmallow_field: marshmallow.fields.Field,
106-
metadata: t.Optional[t.Mapping[object, object]] = None,
106+
metadata: t.Mapping[object, object] = {},
107107
**kw: object,
108108
) -> object:
109109
"""Specify a marshmallow field in the metadata for a ``dataclasses.dataclass``.
@@ -114,9 +114,6 @@ def field(
114114
class A:
115115
x: int = desert.field(marshmallow.fields.Int())
116116
"""
117-
if metadata is None:
118-
metadata = {}
119-
120117
meta: t.Dict[object, object] = create_metadata(marshmallow_field)
121118
meta.update(metadata)
122119

@@ -133,7 +130,7 @@ def ib(
133130
marshmallow_field: marshmallow.fields.Field,
134131
*,
135132
default: t.Union[T, t.Callable[[], T]],
136-
metadata: t.Optional[t.Mapping[object, object]] = None,
133+
metadata: t.Mapping[object, object] = {},
137134
**kw: object,
138135
) -> T:
139136
...
@@ -144,7 +141,7 @@ def ib(
144141
marshmallow_field: marshmallow.fields.Field,
145142
*,
146143
factory: t.Callable[[], T],
147-
metadata: t.Optional[t.Mapping[object, object]] = None,
144+
metadata: t.Mapping[object, object] = {},
148145
**kw: object,
149146
) -> T:
150147
...
@@ -154,7 +151,7 @@ def ib(
154151
def ib(
155152
marshmallow_field: marshmallow.fields.Field,
156153
*,
157-
metadata: t.Optional[t.Mapping[object, object]] = None,
154+
metadata: t.Mapping[object, object] = {},
158155
**kw: object,
159156
) -> object:
160157
...
@@ -166,7 +163,7 @@ def ib(
166163
# plugin that indicates the actual type.
167164
def ib(
168165
marshmallow_field: marshmallow.fields.Field,
169-
metadata: t.Optional[t.Mapping[object, object]] = None,
166+
metadata: t.Mapping[object, object] = {},
170167
**kw: object,
171168
) -> object:
172169
"""Specify a marshmallow field in the metadata for an ``attr.dataclass``.
@@ -177,9 +174,6 @@ def ib(
177174
class A:
178175
x: int = desert.ib(marshmallow.fields.Int())
179176
"""
180-
if metadata is None:
181-
metadata = {}
182-
183177
meta: t.Dict[object, object] = create_metadata(marshmallow_field)
184178
meta.update(metadata)
185179
new_field: attr._make._CountingAttr = attr.ib(**kw, metadata=meta) # type: ignore[call-overload]

0 commit comments

Comments
 (0)