Skip to content

Commit bab4dd0

Browse files
committed
_dependee_fixture_argnames: return tuple
Note: black cannot parse `return *active_fixture_argnames, *self.argnames` yet (fixed in master, psf/black#1121). Tested manually using: ```python @pytest.fixture(scope="session") def xdist_suffix(request): print("\nxdist_suffix") suffixes.append("xdist") @pytest.fixture(scope="session") def parallel_suffix(tox_suffix, xdist_suffix): pass def test_suffix(parallel_suffix): assert suffixes == ["tox", "xdist"] ``` When using a set there the order is not deterministic, i.e. the test is flaky.
1 parent 1bcb0c0 commit bab4dd0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/_pytest/fixtures.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@ def _dependee_fixture_argnames(self, request):
962962

963963
stack_slice_index = min([current_fix_index, *parent_fixture_indexes])
964964
active_fixture_argnames = all_fix_names[:stack_slice_index]
965-
return {*active_fixture_argnames, *self.argnames}
965+
return tuple(active_fixture_argnames) + self.argnames
966966

967967
def cache_key(self, request):
968968
return request.param_index if not hasattr(request, "param") else request.param

0 commit comments

Comments
 (0)