Skip to content

Commit ecd0ab2

Browse files
committed
Deprecate rsync support
Fix #825
1 parent ab95a4b commit ecd0ab2

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

docs/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Features
3434
* ``--looponfail``: run your tests repeatedly in a subprocess. After each run
3535
pytest waits until a file in your project changes and then re-runs
3636
the previously failing tests. This is repeated until all tests pass
37-
after which again a full run is performed.
37+
after which again a full run is performed (DEPRECATED).
3838

3939
* :ref:`Multi-Platform` coverage: you can specify different Python interpreters
4040
or different platforms and run tests in parallel on all of them.

docs/remote.rst

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,17 @@
55
Sending tests to remote SSH accounts
66
====================================
77

8+
.. deprecated:: 3.0
9+
10+
.. warning::
11+
12+
This feature is deprecated because the support for ``rsync`` is faulty
13+
in terms of reproducing the development environment in the remote
14+
worker, and there is no clear solution moving forward.
15+
16+
This feature is scheduled to be removed in release 4.0, to let the team
17+
focus on a smaller set of features.
18+
819
Suppose you have a package ``mypkg`` which contains some
920
tests that you can successfully run locally. And you
1021
have a ssh-reachable machine ``myhost``. Then

src/xdist/plugin.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,13 @@ def pytest_configure(config):
196196
)
197197
config.issue_config_time_warning(warning, 2)
198198

199+
if config.getoption("rsyncdir", None) or config.getini("rsyncdirs"):
200+
warning = DeprecationWarning(
201+
"The --rsyncdir command line argument and rsyncdirs config variable are deprecated.\n"
202+
"The rsync feature will be removed in pytest-xdist 4.0."
203+
)
204+
config.issue_config_time_warning(warning, 2)
205+
199206
config_line = (
200207
"xdist_group: specify group for tests should run in same session."
201208
"in relation to one another. " + "Provided by pytest-xdist."

0 commit comments

Comments
 (0)