Use exitcodes.

Author: tobiasraabe

tests/test_cli.py

@@ -5,6 +5,7 @@
 
 import pytest
 from pytask import cli
+from pytask import ExitCode
 
 
 @pytest.mark.end_to_end
@@ -22,5 +23,5 @@ def task_1(produces):
     result = runner.invoke(cli, [tmp_path.as_posix(), "-n", "2", "--delay", "5"])
     end = time()
 
-    assert result.exit_code == 0
+    assert result.exit_code == ExitCode.OK
     assert end - start > 5

tests/test_config.py

@@ -4,6 +4,7 @@
 import textwrap
 
 import pytest
+from pytask import ExitCode
 from pytask import main
 from pytask_parallel.backends import PARALLEL_BACKENDS
 
@@ -29,15 +30,15 @@ def test_interplay_between_debugging_and_parallel(tmp_path, pdb, n_workers, expe
 @pytest.mark.parametrize(
     "configuration_option, value, exit_code",
     [
-        ("n_workers", "auto", 0),
-        ("n_workers", 1, 0),
-        ("n_workers", 2, 0),
-        ("delay", 0.1, 0),
-        ("delay", 1, 0),
-        ("parallel_backend", "unknown_backend", 2),
+        ("n_workers", "auto", ExitCode.OK),
+        ("n_workers", 1, ExitCode.OK),
+        ("n_workers", 2, ExitCode.OK),
+        ("delay", 0.1, ExitCode.OK),
+        ("delay", 1, ExitCode.OK),
+        ("parallel_backend", "unknown_backend", ExitCode.CONFIGURATION_FAILED),
     ]
     + [
-        ("parallel_backend", parallel_backend, 0)
+        ("parallel_backend", parallel_backend, ExitCode.OK)
         for parallel_backend in PARALLEL_BACKENDS
     ],
 )
@@ -55,5 +56,5 @@ def test_reading_values_from_config_file(
     assert session.exit_code == exit_code
     if value == "auto":
         value = os.cpu_count() - 1
-    if session.exit_code == 0:
+    if session.exit_code == ExitCode.OK:
         assert session.config[configuration_option] == value

tests/test_execute.py

@@ -7,6 +7,7 @@
 
 import pytest
 from pytask import cli
+from pytask import ExitCode
 from pytask import main
 from pytask import Task
 from pytask_parallel.backends import PARALLEL_BACKENDS
@@ -39,7 +40,7 @@ def task_2(produces):
 
     session = main({"paths": tmp_path})
 
-    assert session.exit_code == 0
+    assert session.exit_code == ExitCode.OK
     assert session.execution_end - session.execution_start > 10
 
     tmp_path.joinpath("out_1.txt").unlink()
@@ -49,7 +50,7 @@ def task_2(produces):
         {"paths": tmp_path, "n_workers": 2, "parallel_backend": parallel_backend}
     )
 
-    assert session.exit_code == 0
+    assert session.exit_code == ExitCode.OK
     assert session.execution_end - session.execution_start < 10
 
 
@@ -76,7 +77,7 @@ def task_2(produces):
     result = runner.invoke(cli, [tmp_path.as_posix()])
     end = time()
 
-    assert result.exit_code == 0
+    assert result.exit_code == ExitCode.OK
     assert end - start > 10
 
     tmp_path.joinpath("out_1.txt").unlink()
@@ -95,7 +96,7 @@ def task_2(produces):
     )
     end = time()
 
-    assert result.exit_code == 0
+    assert result.exit_code == ExitCode.OK
     assert "Started 2 workers." in result.output
     assert end - start < 10
 
@@ -162,6 +163,7 @@ def task_2(produces):
         }
     )
 
+    assert session.exit_code == ExitCode.OK
     assert 3 < session.execution_end - session.execution_start < 10
 
 
@@ -190,6 +192,7 @@ def task_3():
         }
     )
 
+    assert session.exit_code == ExitCode.OK
     assert len(session.tasks) == 3
     assert len(session.execution_reports) == 2
 
@@ -229,7 +232,7 @@ def task_5():
         {"paths": tmp_path, "parallel_backend": parallel_backend, "n_workers": 2}
     )
 
-    assert session.exit_code == 0
+    assert session.exit_code == ExitCode.OK
     first_task_name = session.execution_reports[0].task.name
     assert first_task_name.endswith("task_0") or first_task_name.endswith("task_3")
     last_task_name = session.execution_reports[-1].task.name
@@ -256,7 +259,7 @@ def task_raising_error():
         args.append("--show-locals")
     result = runner.invoke(cli, args)
 
-    assert result.exit_code == 1
+    assert result.exit_code == ExitCode.FAILED
     assert "───── Traceback" in result.output
     assert ("───── locals" in result.output) is show_locals
     assert ("[0, 1, 2, 3, 4]" in result.output) is show_locals
@@ -285,4 +288,4 @@ def task_example(produces):
         {"paths": tmp_path, "parallel_backend": parallel_backend, "n_workers": 2}
     )
 
-    assert session.exit_code == 0
+    assert session.exit_code == ExitCode.OK