test: refactor test case to parametrize

Extract test cases from inline to make it clearer which permutations are
being tested.

Signed-off-by: Mike Fiedler <[email protected]>

Author: miketheman

tests/unit/rss/test_views.py

@@ -13,6 +13,7 @@
 import datetime
 
 import pretend
+import pytest
 
 from warehouse.rss import views as rss
 
@@ -102,36 +103,39 @@ def test_rss_project_releases(db_request):
     assert db_request.response.content_type == "text/xml"
 
 
-def test_format_author(db_request):
+@pytest.mark.parametrize(
+    ("author_email", "expected"),
+    [
+        (None, None),
+        ("", None),
+        ("UNKNOWN", None),
+        ("[email protected], UNKNOWN", None),
+        ("[email protected]", "[email protected]"),
+        ("No Reply <[email protected]>", "[email protected]"),
+        (
+            (
+                # simple, no spaces
+                "[email protected],"
+                # space after
+                "[email protected] ,"
+                # space before, incl realname
+                " No Reply <[email protected]>,"
+                # two spaces before, angle brackets
+                "  <[email protected]>"
+            ),
+            ", ".join(["[email protected]"] * 4),
+        ),
+    ],
+)
+def test_format_author(db_request, author_email, expected):
     db_request.find_service = pretend.call_recorder(
         lambda *args, **kwargs: pretend.stub(
             enabled=False, csp_policy=pretend.stub(), merge=lambda _: None
         )
     )
-
     db_request.session = pretend.stub()
 
-    project = ProjectFactory.create()
-    release = ReleaseFactory.create(project=project)
-
-    release.author_email = "[email protected]"
-    assert rss._format_author(release) == release.author_email
-
-    release.author_email = "No Reply <[email protected]>"
-    assert rss._format_author(release) == "[email protected]"
-
-    for invalid in (None, "", "UNKNOWN", "[email protected], UNKNOWN"):
-        release.author_email = invalid
-        assert rss._format_author(release) is None
-
-    release.author_email = (
-        # simple, no spaces
-        "[email protected],"
-        # space after
-        "[email protected] ,"
-        # space before, incl realname
-        " No Reply <[email protected]>,"
-        # two spaces before, angle brackets
-        "  <[email protected]>"
-    )
-    assert rss._format_author(release) == ", ".join(["[email protected]"] * 4)
+    release = ReleaseFactory.create()
+
+    release.author_email = author_email
+    assert rss._format_author(release) == expected