Warn for uppercase key usage in metadata in setup.cfg, provides compatibility. Fixes #2592 #2593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissa-kun-li
changed the title
webknjaz
reviewed
Mar 7, 2021
webknjaz
reviewed
Mar 7, 2021
webknjaz
reviewed
Mar 7, 2021
webknjaz
reviewed
Mar 7, 2021
webknjaz
reviewed
Mar 7, 2021
jaraco
reviewed
Mar 7, 2021
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
jaraco
force-pushed
the
uppercase_metadata_warning
branch
from
2d6453e to
66323ad
Compare
Member
|
Thanks Melissa for the follow up and quick response. Thanks Sviatoslav for the edits. |
Contributor
Author
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #2592
This will warn users if they use an uppercase key in
metadatainsetup.cfg. This will also convert any uppercase keys inmetadatato lowercase to restore some compatibility due to the change by #2580 in which keys insetup.cfgbecame case-sensitive.Pull Request Checklist
changelog.d/.(See documentation for details)