remove kwargs client #2244
Merged
remove kwargs client #2244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiversen
force-pushed
the
kwargs5
branch
2 times, most recently
from
72a7175 to
f5621bc
Compare
janiversen
force-pushed
the
kwargs5
branch
4 times, most recently
from
5b3d564 to
086f166
Compare
sjrodahl
reviewed
Aug 1, 2024
Comment on lines
-60
to
+64
| port: int = 502, | ||
| framer: FramerType = FramerType.SOCKET, | ||
| port: int = 502, |
There was a problem hiding this comment.
For reference: this breaks the interface for those who used port as a positional argument
Collaborator
Author
There was a problem hiding this comment.
Yes, as noted in API changes.
But it still allows using port as a positional parameter, we just changed the order! using optional parameters as positional is very dangerous since optional parameters can change position without notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargs is gone from all clients !!!
Hopefully that will reduce the number of questions about wrong parameters.