Skip to content

Get rid of dummy type input to RVs #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Apr 10, 2024 · 0 comments · Fixed by #691
Closed

Get rid of dummy type input to RVs #701

ricardoV94 opened this issue Apr 10, 2024 · 0 comments · Fixed by #691

Comments

@ricardoV94
Copy link
Member

Description

RandomVariables third input is a numerical integer than indexes into a list of predefined types to indicate if a variable is float64 or float32, ...

This input is useless because PyTensor variables are not allowed to change types at runtime. We should make it a property of the Op. This requires defining Ops dynamically whenever they are initialized, which means there is no canonical pt.random.normal. This is not too bad imo and simplifies handling (and visualizing) RV graphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant