Skip to content

Deprecate SumTo1 Transform #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #7053
ricardoV94 opened this issue Nov 14, 2023 · 6 comments
Open
Tracked by #7053

Deprecate SumTo1 Transform #7009

ricardoV94 opened this issue Nov 14, 2023 · 6 comments

Comments

@ricardoV94
Copy link
Member

Description

This seems to be an old transform that was replaced by the Simplex transform.

@PulsatingGenius
Copy link

i want to work on this issue .

@twiecki
Copy link
Member

twiecki commented Nov 22, 2023

@PulsatingGenius Great, just open a PR (can be draft too).

@nyeshlur
Copy link

Hello if this issue is not currently being worked on I would like to work on it. I was wondering what needs to be included in a draft pull request?

@ricardoV94
Copy link
Member Author

For now just a FutureWarning when users access the transform to let them know it's deprecated and will be removed in the future

Plus a test that verified the warning is working but you can still access it

@nyeshlur
Copy link

Hi so I have created a FutureWarning in pymc/distributions/transforms.py and I have written a test in tests/distributions/test_transform.py. I'm not sure if this is what is needed and I'm also unsure of how to run the test. Any help is appreciated.

@ricardoV94
Copy link
Member Author

Thanks, I'll take a look but in the meantime this may give you some hints: https://www.pymc.io/projects/docs/en/stable/contributing/running_the_test_suite.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants