Only pack variables for which prior samples are available (#5338)

Closes #5337

Author: michaelosthege

pymc/backends/arviz.py

@@ -412,7 +412,7 @@ def priors_to_xarray(self):
         if self.prior is None:
             return {"prior": None, "prior_predictive": None}
         if self.observations is not None:
-            prior_predictive_vars = list(self.observations.keys())
+            prior_predictive_vars = list(set(self.observations).intersection(self.prior))
             prior_vars = [key for key in self.prior.keys() if key not in prior_predictive_vars]
         else:
             prior_vars = list(self.prior.keys())

pymc/tests/test_idata_conversion.py

@@ -572,6 +572,17 @@ def test_priors_separation(self, use_context):
         fails = check_multiple_attrs(test_dict, inference_data)
         assert not fails
 
+    def test_conversion_from_variables_subset(self):
+        """This is a regression test for issue #5337."""
+        with pm.Model() as model:
+            x = pm.Normal("x")
+            pm.Normal("y", x, observed=5)
+            idata = pm.sample(
+                tune=10, draws=20, chains=1, step=pm.Metropolis(), compute_convergence_checks=False
+            )
+            pm.sample_posterior_predictive(idata, var_names=["x"])
+            pm.sample_prior_predictive(var_names=["x"])
+
     def test_multivariate_observations(self):
         coords = {"direction": ["x", "y", "z"], "experiment": np.arange(20)}
         data = np.random.multinomial(20, [0.2, 0.3, 0.5], size=20)