Skip to content

Commit e9a06e6

Browse files
committed
Remove passing xfails
1 parent 6a6a43f commit e9a06e6

File tree

3 files changed

+3
-23
lines changed

3 files changed

+3
-23
lines changed

pymc/tests/sampler_fixtures.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
import sys
15-
16-
import aesara
1714
import aesara.tensor as at
1815
import arviz as az
1916
import numpy as np
@@ -41,15 +38,6 @@ def test_var(self):
4138
samples = self.samples[varname]
4239
npt.assert_allclose(expected, samples.var(0), self.rtol, self.atol)
4340

44-
IS_LINUX = sys.platform == "linux"
45-
IS_FLOAT32 = aesara.config.floatX == "float32"
46-
from pymc.tests.test_posteriors import TestSliceUniform
47-
48-
if IS_LINUX and IS_FLOAT32 and isinstance(self, TestSliceUniform):
49-
raise AssertionError(
50-
"Temporarily fail this test for specific subsytems. See: https://github.com/pymc-devs/pymc/pull/4887#issuecomment-946506545"
51-
)
52-
5341

5442
class KnownCDF:
5543
ks_thin = 5

pymc/tests/test_posteriors.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,10 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
import sys
16-
17-
import aesara
1815
import pytest
1916

2017
from pymc.tests import sampler_fixtures as sf
2118

22-
IS_LINUX = sys.platform == "linux"
23-
IS_FLOAT32 = aesara.config.floatX == "float32"
24-
2519

2620
class TestNUTSUniform(sf.NutsFixture, sf.UniformFixture):
2721
n_samples = 10000
@@ -43,10 +37,6 @@ class TestMetropolisUniform(sf.MetropolisFixture, sf.UniformFixture):
4337
atol = 0.05
4438

4539

46-
@pytest.mark.xfail(
47-
condition=IS_FLOAT32 and IS_LINUX,
48-
reason="Test fails on linux float32 systems. See https://github.com/pymc-devs/pymc/issues/5088",
49-
)
5040
class TestSliceUniform(sf.SliceFixture, sf.UniformFixture):
5141
n_samples = 10000
5242
tune = 1000

pymc/tests/test_transforms.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,9 @@ def transform_params(z=a, y=b):
221221
close_to_logical(vals < b, True, tol)
222222

223223

224-
@pytest.mark.xfail(reason="This test produces infinite values using aeppl")
224+
@pytest.mark.skipif(
225+
aesara.config.floatX == "float32", reason="Test is designed for 64bit precision"
226+
)
225227
def test_interval_near_boundary():
226228
lb = -1.0
227229
ub = 1e-7

0 commit comments

Comments
 (0)