Skip to content

Commit 78e5e69

Browse files
domenzaintwiecki
authored andcommitted
Implement log CDF for Gumbel distribution
1 parent db09f32 commit 78e5e69

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

pymc3/distributions/continuous.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3434,6 +3434,12 @@ def _repr_latex_(self, name=None, dist=None):
34343434
get_variable_name(mu),
34353435
get_variable_name(beta))
34363436

3437+
def logcdf(self, value):
3438+
beta = self.beta
3439+
mu = self.mu
3440+
3441+
return -tt.exp(-(value - mu)/beta)
3442+
34373443

34383444
class Rice(PositiveContinuous):
34393445
R"""

pymc3/tests/test_distributions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,6 +1126,10 @@ def gumbel(value, mu, beta):
11261126
return floatX(sp.gumbel_r.logpdf(value, loc=mu, scale=beta))
11271127
self.pymc3_matches_scipy(Gumbel, R, {'mu': R, 'beta': Rplusbig}, gumbel)
11281128

1129+
def gumbellcdf(value, mu, beta):
1130+
return floatX(sp.gumbel_r.logcdf(value, loc=mu, scale=beta))
1131+
self.check_logcdf(Gumbel, R, {'mu': R, 'beta': Rplusbig}, gumbellcdf)
1132+
11291133
def test_logistic(self):
11301134
self.pymc3_matches_scipy(Logistic, R, {'mu': R, 's': Rplus},
11311135
lambda value, mu, s: sp.logistic.logpdf(value, mu, s),

0 commit comments

Comments
 (0)