Merge branch 'main' of https://github.com/PyCQA/pylint into false_positive_type_checking

Author: zenlyj

doc/data/messages/b/bad-configuration-section/details.rst

@@ -1 +1,2 @@
-You can help us make the doc better `by contributing <https://github.com/PyCQA/pylint/issues/5953>`_ !
+This error was raised when we encountered an unexpected value type in a toml
+configuration between pylint 2.12 and pylint 2.14 (before the argparse refactor).

doc/data/messages/b/bad-configuration-section/good.py

@@ -0,0 +1,44 @@
+def fifty_percent_off(whole):
+    return (float(whole)) * 50 / 100
+
+
+def calculate_sum_and_display_price_of_fruits(*fruits):  # [too-complex]
+    # McCabe rating is 13 here (by default 10)
+    shopping_list = []
+
+    if "apple" in fruits:
+        v = fifty_percent_off(1.1)
+        shopping_list.append(v)
+    if "pear" in fruits:
+        shopping_list.append(0.8)
+    if "banana" in fruits:
+        shopping_list.append(1.2)
+    if "mango" in fruits:
+        shopping_list.append(3.5)
+    if "peach" in fruits:
+        shopping_list.append(0.5)
+    if "melon" in fruits:
+        shopping_list.append(4.9)
+    if "orange" in fruits:
+        shopping_list.append(2.0)
+    if "strawberry" in fruits:
+        shopping_list.append(2.5)
+    if "mandarin" in fruits:
+        shopping_list.append(2.3)
+    if "plum" in fruits:
+        shopping_list.append(0.5)
+    if "watermelon" in fruits:
+        v = fifty_percent_off(6.4)
+        shopping_list.append(v)
+
+    combine = zip(fruits, shopping_list)
+
+    for i in combine:
+        print(f"{i[0]} ${i[1]:.2f}")
+
+    total = sum(shopping_list)
+    print(f"Total price is ${total:.2f}")
+
+
+fruits_to_buy = ["apple", "orange", "watermelon"]
+calculate_sum_and_display_price_of_fruits(*fruits_to_buy)

doc/data/messages/p/parse-error/good.py

@@ -1 +1,40 @@
-# This is a placeholder for correct code for this message.
+FRUIT_PRICES = {
+    "apple": 1.1,
+    "pear": 0.8,
+    "banana": 1.2,
+    "mango": 3.5,
+    "peach": 0.5,
+    "melon": 4.9,
+    "orange": 2.0,
+    "strawberry": 2.5,
+    "mandarin": 2.3,
+    "plum": 0.5,
+    "watermelon": 6.4,
+}
+DISCOUNTED_FRUITS = ["apple", "watermelon"]
+
+
+def fifty_percent_off(whole):
+    return (float(whole)) * 50 / 100
+
+
+def get_price(fruit):
+    full_price = FRUIT_PRICES.get(fruit)
+    if fruit in DISCOUNTED_FRUITS:
+        return fifty_percent_off(full_price)
+    else:
+        return full_price
+
+
+def display_fruit_and_price(fruits):
+    for fruit in fruits:
+        print(f"{fruit} ${get_price(fruit) :.2f}")
+
+
+def get_total(fruits):
+    return sum(get_price(f) for f in fruits)
+
+
+fruits_to_buy = ["apple", "orange", "watermelon"]
+display_fruit_and_price(fruits_to_buy)
+print(f"Total price is ${get_total(fruits_to_buy):.2f}")

doc/data/messages/t/too-complex/bad.py

@@ -0,0 +1,3 @@
+[main]
+
+load-plugins=pylint.extensions.mccabe

doc/data/messages/t/too-complex/details.rst

@@ -0,0 +1 @@
+f"python {3.5} is past end of life"  # [using-f-string-in-unsupported-version]

doc/data/messages/t/too-complex/good.py

@@ -1 +1 @@
-You can help us make the doc better `by contributing <https://github.com/PyCQA/pylint/issues/5953>`_ !
+f-strings were introduced in Python version 3.6; to use them, please use a more recent version of Python.

doc/data/messages/t/too-complex/pylintrc

@@ -1 +1 @@
-# This is a placeholder for correct code for this message.
+"python {} is past end of life".format(3.5)

doc/data/messages/u/using-f-string-in-unsupported-version/bad.py

@@ -0,0 +1,2 @@
+[main]
+py-version=3.5

doc/data/messages/u/using-f-string-in-unsupported-version/details.rst

@@ -414,8 +414,8 @@ def _write_redirect_old_page(
     )
     content = f""".. _{old_name[0]}:
 
-{get_rst_title("/".join(old_name), "=")}
-"{old_name[0]} has been renamed. The new message can be found at:
+{get_rst_title(" / ".join(old_name), "=")}
+'{old_name[0]}' has been renamed. The new message can be found at:
 
 .. toctree::
    :maxdepth: 2

doc/data/messages/u/using-f-string-in-unsupported-version/good.py

@@ -32,6 +32,20 @@ Last but not least @clavedeluna and @nickdrozd became triagers, welcome to the t
 
 .. towncrier release notes start
 
+What's new in Pylint 2.16.1?
+----------------------------
+Release date: 2023-02-02
+
+
+Other Bug Fixes
+---------------
+
+- Fix a crash happening for python interpreter < 3.9 following a failed typing
+  update.
+
+  Closes #8161 (`#8161 <https://github.com/PyCQA/pylint/issues/8161>`_)
+
+
 What's new in Pylint 2.16.0?
 ----------------------------
 Release date: 2023-02-01

doc/data/messages/u/using-f-string-in-unsupported-version/pylintrc

@@ -1,5 +1,5 @@
 """"Checks for redundant Union typehints in assignments"""
-# pylint: disable=deprecated-typing-alias,consider-alternative-union-syntax,consider-using-alias
+# pylint: disable=deprecated-typing-alias,consider-alternative-union-syntax,consider-using-alias,invalid-name,unused-argument,missing-function-docstring
 
 from __future__ import annotations
 from typing import Union, Optional, Sequence
@@ -19,3 +19,16 @@
 ANSWER_10: dict | list[int] | float | str | int | bool = 10
 #  +1: [redundant-typehint-argument]
 ANSWER_11: list[int] | dict[int] | dict[list[int]] | list[str] | list[str] = ['string']
+
+# Multiple warnings for the same repeated type
+#  +1: [redundant-typehint-argument, redundant-typehint-argument, redundant-typehint-argument]
+x: int | int | int | int
+
+# No warning for redundant types in compound type (yet !)
+z: dict[int | int, str | str]
+
+#  +1: [redundant-typehint-argument]
+zz: dict[int | int, str | str] | dict[int | int, str | str]
+
+# No warnings for redundant types in function signature (yet !)
+def f(p: int | int) -> str | str: ...

doc/exts/pylint_messages.py

@@ -7,3 +7,7 @@ redundant-typehint-argument:16:0:16:82::Type `list[str]` is used more than once
 redundant-typehint-argument:17:0:17:23::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
 redundant-typehint-argument:18:0:18:43::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
 redundant-typehint-argument:21:0:21:87::Type `list[str]` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:31:0:31:59::Type `dict[int | int, str | str]` is used more than once in union type annotation. Remove redundant typehints.:HIGH

doc/whatsnew/2/2.16/index.rst

@@ -0,0 +1,40 @@
+""""Checks for redundant Union typehints in assignments"""
+# pylint: disable=deprecated-typing-alias,consider-alternative-union-syntax,consider-using-alias,invalid-name,unused-argument,missing-function-docstring
+
+from __future__ import annotations
+from typing import Union, Optional, Sequence
+
+#  +1: [redundant-typehint-argument, redundant-typehint-argument]
+ANSWER_0: Union[int, int, str, bool, float, str] = 0
+ANSWER_1: Optional[int] = 1
+ANSWER_2: Sequence[int] = [2]
+ANSWER_3: Union[list[int], str, int, bool, list[int]] = 3  # [redundant-typehint-argument]
+ANSWER_4: Optional[None] = None   # [redundant-typehint-argument]
+ANSWER_5: Optional[list[int]] = None
+ANSWER_6: Union[None, None] = None   # [redundant-typehint-argument]
+#  +1: [redundant-typehint-argument]
+ANSWER_7: Union[list[int], dict[int], dict[list[int]], list[str], list[str]] = [7]
+ANSWER_8: int | int = 8  # [redundant-typehint-argument]
+ANSWER_9: str | int | None | int | bool = 9   # [redundant-typehint-argument]
+ANSWER_10: dict | list[int] | float | str | int | bool = 10
+#  +1: [redundant-typehint-argument]
+ANSWER_11: list[int] | dict[int] | dict[list[int]] | list[str] | list[str] = ['string']
+
+# Multiple warnings for the same repeated type
+#  +1: [redundant-typehint-argument, redundant-typehint-argument, redundant-typehint-argument]
+x: int | int | int | int
+
+# No warning for type alias (yet !)
+Q = int | int
+QQ = Q | Q
+
+q: Q | Q  # [redundant-typehint-argument]
+
+# No warning for redundant types in compound type (yet !)
+z: dict[int | int, str | str]
+
+#  +1: [redundant-typehint-argument]
+zz: dict[int | int, str | str] | dict[int | int, str | str]
+
+# No warnings for redundant types in function signature (yet !)
+def f(p: int | int) -> str | str: ...

tests/functional/ext/typing/redundant_typehint_argument.py

@@ -0,0 +1,6 @@
+[main]
+py-version=3.10
+load-plugins=pylint.extensions.typing
+
+[testoptions]
+min_pyver=3.10

tests/functional/ext/typing/redundant_typehint_argument.txt

@@ -0,0 +1,14 @@
+redundant-typehint-argument:8:0:8:52::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:8:0:8:52::Type `str` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:11:0:11:57::Type `list[int]` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:12:10:12:24::Type `None` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:14:0:14:34::Type `None` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:16:0:16:82::Type `list[str]` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:17:0:17:23::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:18:0:18:43::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:21:0:21:87::Type `list[str]` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:25:0:25:24::Type `int` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:31:0:31:8::Type `Q` is used more than once in union type annotation. Remove redundant typehints.:HIGH
+redundant-typehint-argument:37:0:37:59::Type `dict[int | int, str | str]` is used more than once in union type annotation. Remove redundant typehints.:HIGH