Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Needed for the pylint feature flag in pylint-dev/pylint#9632
Refs pylint-dev/pylint#9626

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the numpy cleanup make sense too.

@codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (d1c37a9) to head (7aeebe6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
+ Coverage   92.78%   92.79%   +0.01%     
==========================================
  Files          94       94              
  Lines       11102    11109       +7     
==========================================
+ Hits        10301    10309       +8     
+ Misses        801      800       -1     
Flag Coverage Δ
linux 92.60% <88.23%> (+<0.01%) ⬆️
pypy 92.79% <100.00%> (+0.01%) ⬆️
windows 92.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
astroid/interpreter/_import/spec.py 97.46% <100.00%> (-0.02%) ⬇️
astroid/manager.py 89.87% <100.00%> (+0.29%) ⬆️
astroid/modutils.py 88.19% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

@jacobtylerwalls jacobtylerwalls merged commit ee06feb into main May 16, 2024
@jacobtylerwalls jacobtylerwalls deleted the prefer-stubs branch May 16, 2024 11:04
github-actions bot pushed a commit that referenced this pull request May 16, 2024
jacobtylerwalls added a commit that referenced this pull request May 16, 2024
(cherry picked from commit ee06feb)

Co-authored-by: Jacob Walls <[email protected]>
@jacobtylerwalls jacobtylerwalls added backported Assigned once the backport is done and removed backport maintenance/4.0.x labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Assigned once the backport is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants