attach classes to their parent; fix bugs uncovered by this

1. some '__doc__' fields of standard library
   symbols (e.g. WrapperDescriptorType.__doc__) don't return a string,
   they return a 'getset_descriptor'. Thus, an attempt to print "as
   string" fails. The solution is to check that __doc__ is an instance
   of str.

2. A "temporary_class" was attached to a function node, when it
   shouldn't have been. The solution is to reattach it to the adhoc
   module.

Author: temyurchenko

astroid/nodes/node_classes.py

@@ -4,6 +4,8 @@
 
 """Module for some node classes. More nodes in scoped_nodes.py"""
 
+# isort: off
+
 from __future__ import annotations
 
 import abc
@@ -2061,7 +2063,14 @@ def __init__(
         :param end_col_offset: The end column this node appears on in the
             source code. Note: This is after the last symbol.
         """
-        self.value: Any = value
+        if getattr(value, "__name__", None) == "__doc__":
+            raise AssertionError(  # pragma: no cover
+                "You have most likely called a __doc__ field of some object "
+                "and it didn't return a string. "
+                "That happens to some symbols from the standard library. "
+                "Check for isinstance(<X>.__doc__, str)."
+            )
+        self.value = value
         """The value that the constant represents."""
 
         self.kind: str | None = kind  # can be None

astroid/nodes/scoped_nodes/scoped_nodes.py

@@ -179,6 +179,13 @@ def function_to_method(n, klass):
     return n
 
 
+def attach_to_parent(node: NodeNG, name: str, parent: NodeNG):
+    frame = parent.frame()
+    frame.set_local(name, node)
+    if frame is parent:
+        frame._append_node(node)
+
+
 class Module(LocalsDictNodeNG):
     """Class representing an :class:`ast.Module` node.
 
@@ -1168,10 +1175,7 @@ def __init__(
             parent=parent,
         )
         if parent:
-            frame = parent.frame()
-            frame.set_local(name, self)
-            if frame is parent:
-                frame._append_node(self)
+            attach_to_parent(self, name, parent)
 
     def postinit(
         self,
@@ -1627,7 +1631,7 @@ def infer_call_result(
                     col_offset=0,
                     end_lineno=0,
                     end_col_offset=0,
-                    parent=self,
+                    parent=AstroidManager().adhoc_module,
                 )
                 new_class.hide = True
                 new_class.postinit(
@@ -1939,7 +1943,7 @@ def __init__(
             parent=parent,
         )
         if parent:
-            parent.frame().set_local(name, self)
+            attach_to_parent(self, name, parent)
 
         for local_name, node in self.implicit_locals():
             self.add_local_node(node, local_name)

astroid/raw_building.py

@@ -56,7 +56,8 @@ def _add_dunder_class(func, parent: nodes.NodeNG, member) -> None:
     if not cls_name:
         return
     cls_bases = [ancestor.__name__ for ancestor in python_cls.__bases__]
-    ast_klass = build_class(cls_name, parent, cls_bases, python_cls.__doc__)
+    doc = python_cls.__doc__ if isinstance(python_cls.__doc__, str) else None
+    ast_klass = build_class(cls_name, parent, cls_bases, doc)
     func.instance_attrs["__class__"] = [ast_klass]
 
 
@@ -321,7 +322,7 @@ def object_build_function(
         args,
         posonlyargs,
         defaults,
-        member.__doc__,
+        member.__doc__ if isinstance(member.__doc__, str) else None,
         kwonlyargs=kwonlyargs,
         kwonlydefaults=kwonly_defaults,
     )
@@ -359,12 +360,8 @@ def _base_class_object_build(
     """
     class_name = name or getattr(member, "__name__", None) or localname
     assert isinstance(class_name, str)
-    klass = build_class(
-        class_name,
-        node,
-        basenames,
-        member.__doc__,
-    )
+    doc = member.__doc__ if isinstance(member.__doc__, str) else None
+    klass = build_class(class_name, node, basenames, doc)
     klass._newstyle = isinstance(member, type)
     try:
         # limit the instantiation trick since it's too dangerous
@@ -713,11 +710,12 @@ def _astroid_bootstrapping() -> None:
                 end_col_offset=0,
                 parent=astroid_builtin,
             )
+            doc = _type.__doc__ if isinstance(_type.__doc__, str) else None
             klass.postinit(
                 bases=[],
                 body=[],
                 decorators=None,
-                doc_node=nodes.Const(value=_type.__doc__) if _type.__doc__ else None,
+                doc_node=nodes.Const(doc) if doc else None,
             )
             builder.object_build(klass, _type)
             astroid_builtin[_type.__name__] = klass