threading.Lock.acquire has the timeout parameter now.

Close pylint-dev/pylint#2457

Author: PCManticore

ChangeLog

@@ -6,6 +6,10 @@ What's New in astroid 2.1.0?
 ============================
 Release Date: TBA
 
+   * ``threading.Lock.acquire`` has the ``timeout`` parameter now.
+
+     Close PyCQA/pylint#2457
+
    * Pass parameters by keyword name when inferring sequences.
 
      Close PyCQA/pylint#2526

astroid/brain/brain_threading.py

@@ -4,14 +4,13 @@
 
 # Licensed under the LGPL: https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html
 # For details: https://github.com/PyCQA/astroid/blob/master/COPYING.LESSER
-
 import astroid
 
 
 def _thread_transform():
     return astroid.parse('''
     class lock(object):
-        def acquire(self, blocking=True):
+        def acquire(self, blocking=True, timeout=-1):
             pass
         def release(self):
             pass

astroid/tests/unittest_brain.py

@@ -488,7 +488,18 @@ def test_multiprocessing_manager(self):
 
 class ThreadingBrainTest(unittest.TestCase):
     def test_lock(self):
-        self._test_lock_object('Lock')
+        lock_instance = builder.extract_node("""
+        import threading
+        threading.Lock()
+        """)
+        inferred = next(lock_instance.infer())
+        self.assert_is_valid_lock(inferred)
+
+        acquire_method = inferred.getattr('acquire')[0]
+        parameters = [
+            param.name for param in acquire_method.args.args[1:]
+        ]
+        assert parameters == ['blocking', 'timeout']
 
     def test_rlock(self):
         self._test_lock_object('RLock')