Skip to content

Commit 17360c4

Browse files
committed
fixup! control setting nodes as local outside of the constructor
1 parent 2ae573b commit 17360c4

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

astroid/raw_building.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,9 @@ def _build_from_function(
397397
filename = getattr(code, "co_filename", None)
398398
if filename is None:
399399
return object_build_methoddescriptor(node, member)
400-
elif filename != getattr(module, "__file__", None):
401-
return build_dummy(member)
402-
else:
400+
if filename == getattr(module, "__file__", None):
403401
return object_build_function(node, member)
402+
return build_dummy(member)
404403

405404

406405
def _safe_has_attribute(obj, member: str) -> bool:
@@ -497,10 +496,8 @@ def object_build(
497496
child = object_build_class(node, member)
498497
# recursion
499498
self.object_build(child, member)
500-
if alias == "__class__" and child.parent is None:
501-
child.parent = self._done[self._module]
502499
elif inspect.ismethoddescriptor(member):
503-
child = object_build_methoddescriptor(node, member)
500+
child: nodes.NodeNG = object_build_methoddescriptor(node, member)
504501
elif inspect.isdatadescriptor(member):
505502
child = object_build_datadescriptor(node, member)
506503
elif isinstance(member, _CONSTANTS):
@@ -512,12 +509,12 @@ def object_build(
512509
# methods aren't caught by isbuiltin branch.
513510
child = _build_from_function(node, member, self._module)
514511
elif _safe_has_attribute(member, "__all__"):
515-
child = build_module(alias)
512+
child: nodes.NodeNG = build_module(alias)
516513
# recursion
517514
self.object_build(child, member)
518515
else:
519516
# create an empty node so that the name is actually defined
520-
child = build_dummy(member)
517+
child: nodes.NodeNG = build_dummy(member)
521518
if child not in node.locals.get(alias, ()):
522519
node.add_local_node(child, alias)
523520
return None

0 commit comments

Comments
 (0)