Skip to content

minimum version and non-semantic versioning (netCDF4) #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathause opened this issue Feb 27, 2021 · 1 comment · Fixed by #4982
Closed

minimum version and non-semantic versioning (netCDF4) #4970

mathause opened this issue Feb 27, 2021 · 1 comment · Fixed by #4982

Comments

@mathause
Copy link
Collaborator

We currently pin netCDF4 to version 1.5. However, I think netCDF4 does not really follow semantic versioning, e.g. python 2 support was dropped in version 1.5.6. So they may actually be doing something like 1.major.minor[.patch] - I asked about their versioning scheme in Unidata/netcdf4-python#1090.

So I wonder if we would need to pin netCDF to version to version 1.5.4.

@mathause
Copy link
Collaborator Author

1.major.minor sounds about right.

See Unidata/netcdf4-python#1090 (comment)

Notes

  • Currently netcdf4=1.5 is required which would imply version 1.5.6. However, due to deprecate pynio backend #4491 version 1.5.3 is currently tested in ubuntu-latest py37-min-all-deps.
  • ci/min_deps_check.py is written for the format major.minor.patch so this is currently not written for this scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant