Skip to content

Add xr.unify_chunks top level method #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcherian opened this issue Oct 3, 2019 · 4 comments · Fixed by #5445
Closed

Add xr.unify_chunks top level method #3371

dcherian opened this issue Oct 3, 2019 · 4 comments · Fixed by #5445

Comments

@dcherian
Copy link
Contributor

dcherian commented Oct 3, 2019

This should handle multiple DataArrays and Datasets.

Implemented in #3276 as Dataset.unify_chunks and DataArray.unify_chunks

@max-sixty
Copy link
Collaborator

Should we have a separate namespace for backend-specific functions? Or we're coupled to dask enough that we may as well add to the top level?

@dcherian
Copy link
Contributor Author

dcherian commented Oct 3, 2019

OK with either

@shoyer
Copy link
Member

shoyer commented Oct 4, 2019

I think we are coupled enough to dask that we may as well add a top-level method/function.

I would lean towards xarray.unify_chunks rather than Dataset/DataArray methods for consistency with xarray.align and xarray.broadcast.

@dcherian
Copy link
Contributor Author

dcherian commented Oct 4, 2019

But unlike align it makes sense to unify chunks of a dataset or dataarray because two variables may be chunked differently along the same dimension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants