Raise proper error for scalar array when coords is a dict (#3271)

* Dims and shape check when coords is a dict

* Update test to the correct raise message

* Move logic and change raise message

Author: griverat

xarray/core/dataarray.py

@@ -113,6 +113,11 @@ def _infer_coords_and_dims(
                 coord = as_variable(coord, name=dims[n]).to_index_variable()
                 dims[n] = coord.name
         dims = tuple(dims)
+    elif len(dims) != len(shape):
+        raise ValueError(
+            "different number of dimensions on data "
+            "and dims: %s vs %s" % (len(shape), len(dims))
+        )
     else:
         for d in dims:
             if not isinstance(d, str):

xarray/tests/test_dataarray.py

@@ -1468,7 +1468,7 @@ def test_init_value(self):
         actual = DataArray(coords=[("x", np.arange(10)), ("y", ["a", "b"])])
         assert_identical(expected, actual)
 
-        with pytest.raises(KeyError):
+        with raises_regex(ValueError, "different number of dim"):
             DataArray(np.array(1), coords={"x": np.arange(10)}, dims=["x"])
         with raises_regex(ValueError, "does not match the 0 dim"):
             DataArray(np.array(1), coords=[("x", np.arange(10))])