Skip to content

Commit 3ceb038

Browse files
ginggsshoyer
authored andcommitted
XFAIL tests failing on ARM (#2334)
* XFAIL tests failing on ARM These tests are expected to fail on ARM due to the following issue in NumPy: numpy/numpy#8325 * PEP 8
1 parent 9438390 commit 3ceb038

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

xarray/tests/__init__.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@
3131
except ImportError:
3232
pass
3333

34+
import platform
35+
arm_xfail = pytest.mark.xfail(platform.machine() == 'aarch64' or
36+
'arm' in platform.machine(),
37+
reason='expected failure on ARM')
38+
3439

3540
def _importorskip(modname, minversion=None):
3641
try:

xarray/tests/test_backends.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
requires_cftime, requires_dask, requires_h5fileobj, requires_h5netcdf,
3636
requires_netCDF4, requires_pathlib, requires_pseudonetcdf, requires_pydap,
3737
requires_pynio, requires_rasterio, requires_scipy,
38-
requires_scipy_or_netCDF4, requires_zarr)
38+
requires_scipy_or_netCDF4, requires_zarr, arm_xfail)
3939
from .test_coding_times import (
4040
_ALL_CALENDARS, _NON_STANDARD_CALENDARS, _STANDARD_CALENDARS)
4141
from .test_dataset import create_test_data, create_append_test_data
@@ -400,6 +400,7 @@ def test_roundtrip_string_encoded_characters(self):
400400
assert_identical(expected, actual)
401401
assert actual['x'].encoding['_Encoding'] == 'ascii'
402402

403+
@arm_xfail
403404
def test_roundtrip_numpy_datetime_data(self):
404405
times = pd.to_datetime(['2000-01-01', '2000-01-02', 'NaT'])
405406
expected = Dataset({'t': ('t', times), 't0': times[0]})

xarray/tests/test_coding_times.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from . import (
1818
assert_array_equal, has_cftime, has_cftime_or_netCDF4, has_dask,
19-
requires_cftime, requires_cftime_or_netCDF4)
19+
requires_cftime, requires_cftime_or_netCDF4, arm_xfail)
2020

2121
try:
2222
from pandas.errors import OutOfBoundsDatetime
@@ -470,6 +470,7 @@ def test_decode_360_day_calendar():
470470
assert_array_equal(actual, expected)
471471

472472

473+
@arm_xfail
473474
@pytest.mark.skipif(not has_cftime_or_netCDF4, reason='cftime not installed')
474475
@pytest.mark.parametrize(
475476
['num_dates', 'units', 'expected_list'],

xarray/tests/test_duck_array_ops.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
from . import (
1919
assert_array_equal, has_dask, has_np113, raises_regex, requires_cftime,
20-
requires_dask)
20+
requires_dask, arm_xfail)
2121

2222

2323
class TestOps:
@@ -252,6 +252,7 @@ def assert_dask_array(da, dask):
252252
assert isinstance(da.data, dask_array_type)
253253

254254

255+
@arm_xfail
255256
@pytest.mark.parametrize('dask', [False, True])
256257
def test_datetime_reduce(dask):
257258
time = np.array(pd.date_range('15/12/1999', periods=11))

0 commit comments

Comments
 (0)