Unhomogeneous translated strings in French

[dbitouze]

@12rambau The French sentence ‘Cliquez pour développer’ (second person imperative) is not consistent with the similar ‘Cliquer pour réduire’ (infinitive mode).

There is another one: ‘Veuillez activer le JavaScript pour que la recherche fonctionne.’), which I think would be better worded as ‘Merci d'activer le JavaScript pour que la recherche fonctionne.’ (infinitive mode rather than imperative mode).

[12rambau]

Thanks @dbitouze I can only agree that the translations are not perfect. Do you have requested access to the transifex portal ?
https://app.transifex.com/12rambau/pydata-sphinx-theme/dashboard/

If not please request access so I can add you in the list of the french moderator and you'll be able to make direct suggestions there

[dbitouze]

@12rambau I'm already a moderator but I can't change those strings: I can only save “as suggestions”.

[trallard]

@dbitouze @12rambau I see some strings were updated in https://github.com/pydata/pydata-sphinx-theme/pull/2009/files, but per @dbitouze's comment above, it seems others might need approval.
But looking into Transifex, everything seems to be translated and approved. https://app.transifex.com/12rambau/pydata-sphinx-theme/viewstrings/#fr/79592a50a377d7a120926189491c3d76?q=reviewed%3Ano

@dbitouze can you check the localised files here and let us know if these are ok now?

Aside. Would it make sense to add @drammock and me as owners/maintainers to Transifex, too? It would be good to have more than one person to approve translations and manage the project to reduce the bus factor here.

[dbitouze]

@trallard The file https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/locale/fr/LC_MESSAGES/sphinx.po is still suboptimal.

On Transifex, everything is translated and (unfortunately) approved but still suboptimal: I can only suggest changes and can't actually change anything.

And there are differences between https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/locale/fr/LC_MESSAGES/sphinx.po and what is on Transifex (I guess that's because https://github.com/pydata/pydata-sphinx-theme/pull/2009/files is still open. BTW, I suggested a change here too).

[12rambau]

The difference you see on transifex is due to the release process. I don't really know these things are piloted.

I would be glad to add extra maintainers to the transifex interface. TBH I would like the project to be fully open and provide complete capacity to anyone to make suggestions. I will play with the interface to see what is possible.

On the validation, I obviously can only review French so I decided to validate all suggestions upfront for other languages. Nothing in French is properly wrong but I agree it could be optimized.

[trallard]

I can help with the Spanish validation if needed.

[12rambau]

@dbitouze I gave you reviewer write as you shown lots of interest in the french language, let me know it it gives you the oportunity to suggest modifications.
@trallard normally you received an invite to be owner of the project. @drammock you need to request access to the project first so I can send you an invite.

[trallard]

Got it, thanks @12rambau!

[dbitouze]

@dbitouze I gave you reviewer write as you shown lots of interest in the french language, let me know if it gives you the opportunity to suggest modifications.

@12rambau Many thanks! It gave me the opportunity, not only to suggest modifications, but to change the translations. That's what I just did for a few of them. I hope it's OK.

[trallard]

That is absolutely fine. I can see a new PR for this so will review it and merge it when I am back tomorrow before making a release.

[trallard]

I just merged these translations so we can close this issue!