Skip to content

Max-width broken with wide elements + for certain widths #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choldgraf opened this issue Mar 7, 2020 · 3 comments · Fixed by #128
Closed

Max-width broken with wide elements + for certain widths #118

choldgraf opened this issue Mar 7, 2020 · 3 comments · Fixed by #128

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented Mar 7, 2020

I found that when we have elements that are quite wide (e.g., a code block with a really long line), then it throws off the whole page's formatting. For example, try building the docs with a line like this:

.. code-block::

    123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789123456789

Both sidebars get scrunched up for me if I add this

@choldgraf
Copy link
Collaborator Author

Looking into it a bit more, it may be something to do with container-fluid? (https://github.com/pandas-dev/pydata-bootstrap-sphinx-theme/blob/e5e71f9bcdb237c52c44984f3c78720be85c6f86/pandas_sphinx_theme/layout.html#L45) also it seems like the max-width: 1024px stuff might be messing stuff up.

Hopefully this can be figured out when #17 (cc @hoetmaaiers who may be interested in this issue if he's also working on that one)

@choldgraf
Copy link
Collaborator Author

I just found an example in the pandas docs where this is messing up right now:

https://pandas.pydata.org/pandas-docs/stable/getting_started/basics.html#basics-rename

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Mar 14, 2020

I see this now as well (if I make my window smaller):

Screenshot from 2020-03-14 18-09-53

But, it seems to happen on almost any page in the pandas docs for me (at least every page that I tried).

In addition, on the page you linked to (so the one with the wide element, https://pandas.pydata.org/pandas-docs/stable/getting_started/basics.html#basics-rename), I see another issue as well:

Screenshot from 2020-03-14 18-13-15

where there is a horizontal scrollbar and the right toc sidebar falls from the page (without actually disappearing in a mobile responsive way).

@jorisvandenbossche jorisvandenbossche changed the title Really wide elements mess up the horizontal spacing Max-width broken with wide elements + for certain widths Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants