Skip to content

get_include seems to be broken with pip version 10.0. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmjarvis opened this issue Apr 16, 2018 · 2 comments
Closed

get_include seems to be broken with pip version 10.0. #30

rmjarvis opened this issue Apr 16, 2018 · 2 comments

Comments

@rmjarvis
Copy link

pip version 10.0 doesn't have a pip.locations. So pybind11.get_include() just returns 'include' after the ImportError.

Workaround for now is to require pip version 9.0.3. But ideal if you could figure out what the right pip function to call is when pip.__version__ > '10.0'.

@SylvainCorlay
Copy link
Member

Thanks for the report!

Cress referencing pybind/pybind11#1190

@rmjarvis
Copy link
Author

Ah. Thanks for the cross-reference. I had meant to be reporting this in the pybind11 issues, but I guess I missed. Closing this in preference for that issue that seems to already have a fix in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants