Skip to content

Commit fb910ae

Browse files
committed
Revert "Fix a memory leak when creating Python3 modules. (#2019)"
This reverts commit 819802d.
1 parent 819802d commit fb910ae

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

include/pybind11/pybind11.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -794,16 +794,11 @@ class module : public object {
794794
explicit module(const char *name, const char *doc = nullptr) {
795795
if (!options::show_user_defined_docstrings()) doc = nullptr;
796796
#if PY_MAJOR_VERSION >= 3
797-
PyModuleDef *def = PyMem_New(PyModuleDef, 1);
797+
PyModuleDef *def = new PyModuleDef();
798798
std::memset(def, 0, sizeof(PyModuleDef));
799799
def->m_name = name;
800800
def->m_doc = doc;
801801
def->m_size = -1;
802-
def->m_free = [](void* module ) {
803-
if (module != nullptr) {
804-
Py_XDECREF(PyModule_GetDef((PyObject*) module));
805-
}
806-
};
807802
Py_INCREF(def);
808803
m_ptr = PyModule_Create(def);
809804
#else

0 commit comments

Comments
 (0)