Skip to content

Commit ece3c55

Browse files
committed
Merge branch 'master' into smart_holder
2 parents f84d291 + bcb6d63 commit ece3c55

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -905,8 +905,7 @@ jobs:
905905
- { sys: mingw64, env: x86_64 }
906906
- { sys: mingw32, env: i686 }
907907
steps:
908-
# Force version because of https://github.com/msys2/setup-msys2/issues/167
909-
- uses: msys2/[email protected]
908+
- uses: msys2/setup-msys2@v2
910909
with:
911910
msystem: ${{matrix.sys}}
912911
install: >-
@@ -936,10 +935,10 @@ jobs:
936935
run: cmake --build build --target pytest -j 2
937936

938937
- name: C++11 tests
939-
run: cmake --build build --target cpptest -j 2
938+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build --target cpptest -j 2
940939

941940
- name: Interface test C++11
942-
run: cmake --build build --target test_cmake_build
941+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build --target test_cmake_build
943942

944943
- name: Clean directory
945944
run: git clean -fdx
@@ -954,10 +953,10 @@ jobs:
954953
run: cmake --build build2 --target pytest -j 2
955954

956955
- name: C++14 tests
957-
run: cmake --build build2 --target cpptest -j 2
956+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build2 --target cpptest -j 2
958957

959958
- name: Interface test C++14
960-
run: cmake --build build2 --target test_cmake_build
959+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build2 --target test_cmake_build
961960

962961
- name: Clean directory
963962
run: git clean -fdx
@@ -972,7 +971,7 @@ jobs:
972971
run: cmake --build build3 --target pytest -j 2
973972

974973
- name: C++17 tests
975-
run: cmake --build build3 --target cpptest -j 2
974+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build3 --target cpptest -j 2
976975

977976
- name: Interface test C++17
978-
run: cmake --build build3 --target test_cmake_build
977+
run: PYTHONHOME=/${{matrix.sys}} PYTHONPATH=/${{matrix.sys}} cmake --build build3 --target test_cmake_build

docs/advanced/classes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ that you are already familiar with the basics from :doc:`/classes`.
99
Overriding virtual functions in Python
1010
======================================
1111

12-
Suppose that a C++ class or interface has a virtual function that we'd like to
12+
Suppose that a C++ class or interface has a virtual function that we'd like
1313
to override from within Python (we'll focus on the class ``Animal``; ``Dog`` is
1414
given as a specific example of how one would do this with traditional C++
1515
code).

0 commit comments

Comments
 (0)