Check unlikely error return from PyDict_DelItemString

virtuald · virtuald · commit eb98f16202c0 · 2021-02-17T01:49:22.000-05:00
diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -690,7 +690,9 @@ class cpp_function : public function {
                                 kwargs = reinterpret_steal<dict>(PyDict_Copy(kwargs.ptr()));
                                 copied_kwargs = true;
                             }
-                            PyDict_DelItemString(kwargs.ptr(), arg_rec.name);
+                            if (PyDict_DelItemString(kwargs.ptr(), arg_rec.name) == -1) {
+                                throw error_already_set();
+                            }
                         } else if (arg_rec.value) {
                             value = arg_rec.value;
                         }

Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,9 @@ class cpp_function : public function {`
`690`	`690`	`kwargs = reinterpret_steal<dict>(PyDict_Copy(kwargs.ptr()));`
`691`	`691`	`copied_kwargs = true;`
`692`	`692`	`}`
`693`		`- PyDict_DelItemString(kwargs.ptr(), arg_rec.name);`
	`693`	`+ if (PyDict_DelItemString(kwargs.ptr(), arg_rec.name) == -1) {`
	`694`	`+ throw error_already_set();`
	`695`	`+ }`
`694`	`696`	`} else if (arg_rec.value) {`
`695`	`697`	`value = arg_rec.value;`
`696`	`698`	`}`