File tree Expand file tree Collapse file tree 1 file changed +3
-2
lines changed Expand file tree Collapse file tree 1 file changed +3
-2
lines changed Original file line number Diff line number Diff line change @@ -2612,12 +2612,13 @@ void print(Args &&...args) {
2612
2612
2613
2613
error_already_set::~error_already_set () {
2614
2614
// Not using py::gil_scoped_acquire here since that calls get_internals,
2615
- // which triggers tensorflow failures (a full explanation is currently unknown).
2615
+ // which is known to trigger failures in the wild (a full explanation is
2616
+ // currently unknown).
2616
2617
// gil_scoped_acquire_local here is a straight copy from get_internals code.
2617
2618
// I.e. py::gil_scoped_acquire acquires the GIL in detail/internals.h exactly
2618
2619
// like we do here now, releases it, then acquires it again in gil.h.
2619
2620
// Using gil_scoped_acquire_local cuts out the get_internals overhead and
2620
- // fixes the tensorflow failures.
2621
+ // fixes the failures observed in the wild. See PR #1895 for more background .
2621
2622
struct gil_scoped_acquire_local {
2622
2623
gil_scoped_acquire_local () : state(PyGILState_Ensure()) {}
2623
2624
~gil_scoped_acquire_local () { PyGILState_Release (state); }
You can’t perform that action at this time.
0 commit comments