Skip to content

Commit bc9315f

Browse files
authored
chore: optimize sparse matrix casting with python tuple (#4064)
* optimize casting of sparse Eigen arrays * move array * Revert for safety
1 parent 6b60d97 commit bc9315f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/pybind11/eigen.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -692,9 +692,9 @@ struct type_caster<Type, enable_if_t<is_eigen_sparse<Type>::value>> {
692692
array outerIndices((rowMajor ? src.rows() : src.cols()) + 1, src.outerIndexPtr());
693693
array innerIndices(src.nonZeros(), src.innerIndexPtr());
694694

695-
return matrix_type(std::make_tuple(
695+
return matrix_type(pybind11::make_tuple(
696696
std::move(data), std::move(innerIndices), std::move(outerIndices)),
697-
std::make_pair(src.rows(), src.cols()))
697+
pybind11::make_tuple(src.rows(), src.cols()))
698698
.release();
699699
}
700700

0 commit comments

Comments
 (0)