Skip to content

Commit 824dc27

Browse files
ax3lrwgk
andauthored
CI: Reenable an NVHPC Test (#4764)
Update from CentOS to Ubuntu and to a recent version of NVHPC (former: PGI). Co-authored-by: Ralf W. Grosse-Kunstleve <[email protected]>
1 parent f870315 commit 824dc27

File tree

1 file changed

+27
-26
lines changed

1 file changed

+27
-26
lines changed

.github/workflows/ci.yml

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -404,54 +404,55 @@ jobs:
404404
# run: cmake --build build --target test_cmake_build
405405

406406

407-
# Testing on CentOS 7 + PGI compilers, which seems to require more workarounds
408-
centos-nvhpc7:
409-
if: ${{ false }} # JOB DISABLED (NEEDS WORK): https://github.com/pybind/pybind11/issues/4690
410-
runs-on: ubuntu-latest
411-
name: "🐍 3 • CentOS7 / PGI 22.9 • x64"
412-
container: centos:7
407+
# Testing on Ubuntu + NVHPC (previous PGI) compilers, which seems to require more workarounds
408+
ubuntu-nvhpc7:
409+
runs-on: ubuntu-20.04
410+
name: "🐍 3 • NVHPC 23.5 • C++17 • x64"
413411

412+
env:
413+
# tzdata will try to ask for the timezone, so set the DEBIAN_FRONTEND
414+
DEBIAN_FRONTEND: 'noninteractive'
414415
steps:
415416
- uses: actions/checkout@v3
416417

417-
- name: Add Python 3 and a few requirements
418-
run: yum update -y && yum install -y epel-release && yum install -y git python3-devel make environment-modules cmake3 yum-utils
418+
- name: Add NVHPC Repo
419+
run: |
420+
echo 'deb [trusted=yes] https://developer.download.nvidia.com/hpc-sdk/ubuntu/amd64 /' | \
421+
sudo tee /etc/apt/sources.list.d/nvhpc.list
419422
420-
- name: Install NVidia HPC SDK
421-
run: yum-config-manager --add-repo https://developer.download.nvidia.com/hpc-sdk/rhel/nvhpc.repo && yum -y install nvhpc-22.9
423+
- name: Install 🐍 3 & NVHPC
424+
run: |
425+
sudo apt-get update -y && \
426+
sudo apt-get install -y cmake environment-modules git python3-dev python3-pip python3-numpy && \
427+
sudo apt-get install -y --no-install-recommends nvhpc-23-5 && \
428+
sudo rm -rf /var/lib/apt/lists/*
429+
python3 -m pip install --upgrade pip
430+
python3 -m pip install --upgrade pytest
422431
423-
# On CentOS 7, we have to filter a few tests (compiler internal error)
424-
# and allow deeper template recursion (not needed on CentOS 8 with a newer
425-
# standard library). On some systems, you many need further workarounds:
432+
# On some systems, you many need further workarounds:
426433
# https://github.com/pybind/pybind11/pull/2475
427434
- name: Configure
428435
shell: bash
429436
run: |
430437
source /etc/profile.d/modules.sh
431-
module load /opt/nvidia/hpc_sdk/modulefiles/nvhpc/22.9
432-
cmake3 -S . -B build -DDOWNLOAD_CATCH=ON \
433-
-DCMAKE_CXX_STANDARD=11 \
438+
module load /opt/nvidia/hpc_sdk/modulefiles/nvhpc/23.5
439+
cmake -S . -B build -DDOWNLOAD_CATCH=ON \
440+
-DCMAKE_CXX_STANDARD=17 \
434441
-DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)") \
435442
-DCMAKE_CXX_FLAGS="-Wc,--pending_instantiations=0" \
436443
-DPYBIND11_TEST_FILTER="test_smart_ptr.cpp"
437444
438-
# Building before installing Pip should produce a warning but not an error
439445
- name: Build
440-
run: cmake3 --build build -j 2 --verbose
441-
442-
- name: Install CMake with pip
443-
run: |
444-
python3 -m pip install --upgrade pip
445-
python3 -m pip install pytest
446+
run: cmake --build build -j 2 --verbose
446447

447448
- name: Python tests
448-
run: cmake3 --build build --target pytest
449+
run: cmake --build build --target pytest
449450

450451
- name: C++ tests
451-
run: cmake3 --build build --target cpptest
452+
run: cmake --build build --target cpptest
452453

453454
- name: Interface test
454-
run: cmake3 --build build --target test_cmake_build
455+
run: cmake --build build --target test_cmake_build
455456

456457

457458
# Testing on GCC using the GCC docker images (only recent images supported)

0 commit comments

Comments
 (0)