Skip to content

Commit 7f124bb

Browse files
committed
Remove the new np.format_parser()-based test, it's much more distracting than useful.
1 parent 38aa697 commit 7f124bb

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

tests/test_buffers.py

-12
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,7 @@ def test_format_descriptor_format(cpp_name, expected_fmts, np_array_dtype):
4444
fmt = m.format_descriptor_format(cpp_name)
4545
assert fmt in expected_fmts
4646

47-
# Everything below just documents long-standing inconsistencies.
48-
# See also: https://github.com/pybind/pybind11/issues/1908
49-
5047
if np_array_dtype is not None:
51-
# py::format_descriptor<> vs np.array:
5248
na = np.array([], dtype=np_array_dtype)
5349
bi = m.get_buffer_info(na)
5450
if fmt in ("i", "q"):
@@ -58,14 +54,6 @@ def test_format_descriptor_format(cpp_name, expected_fmts, np_array_dtype):
5854
else:
5955
assert bi.format == fmt
6056

61-
# py::format_descriptor<> vs np.format_parser():
62-
fmtp = fmt[1:] if fmt.startswith("Z") else fmt
63-
fp = np.format_parser(fmtp, [], [])
64-
assert fp.dtype is not None
65-
66-
# DO NOT try to compare fp.dtype and na.dtype, unless you have a lot of
67-
# spare time to make sense of it and possibly chime in under #1908.
68-
6957

7058
def test_from_python():
7159
with pytest.raises(RuntimeError) as excinfo:

0 commit comments

Comments
 (0)