Fix clang-tidy error: 'auto reg' can be declared as 'auto *reg' [readability-qualified-auto,-warnings-as-errors]

rwgk · rwgk · commit 516811642e8b · 2022-07-15T11:35:17.000-07:00
diff --git a/include/pybind11/detail/type_caster_odr_guard.h b/include/pybind11/detail/type_caster_odr_guard.h
@@ -32,7 +32,7 @@ using type_caster_odr_guard_registry_type = std::unordered_map<std::type_index,
 
 inline type_caster_odr_guard_registry_type &type_caster_odr_guard_registry() {
     // Using the no-destructor idiom (maximizes safety).
-    static auto reg = new type_caster_odr_guard_registry_type();
+    static auto *reg = new type_caster_odr_guard_registry_type();
     return *reg;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ using type_caster_odr_guard_registry_type = std::unordered_map<std::type_index,`
`32`	`32`
`33`	`33`	`inline type_caster_odr_guard_registry_type &type_caster_odr_guard_registry() {`
`34`	`34`	`// Using the no-destructor idiom (maximizes safety).`
`35`		`- static auto reg = new type_caster_odr_guard_registry_type();`
	`35`	`+ static auto *reg = new type_caster_odr_guard_registry_type();`
`36`	`36`	`return *reg;`
`37`	`37`	`}`
`38`	`38`