Skip to content

Commit 472c44e

Browse files
committed
Fix for Windows.
1 parent 9ff6dba commit 472c44e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/ci_sh_def.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ jobs:
167167
-DDOWNLOAD_CATCH=ON
168168
-DDOWNLOAD_EIGEN=ON
169169
-DCMAKE_CXX_STANDARD=17
170-
-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT"
170+
-DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT ${{runner.os == 'Windows' && '/GR /EHsc' || ''}}"
171171
-DPYBIND11_INTERNALS_VERSION=10000000
172172
"-DPYBIND11_TEST_OVERRIDE=test_call_policies.cpp;test_gil_scoped.cpp;test_thread.cpp"
173173
${{ matrix.args }}

.github/workflows/ci_sh_def.yml.patch

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--- ci.yml 2021-09-20 05:57:17.199789637 -0700
2-
+++ ci_sh_def.yml 2021-09-20 06:01:17.683813943 -0700
2+
+++ ci_sh_def.yml 2021-09-20 06:45:40.129525604 -0700
33
@@ -1,4 +1,16 @@
44
-name: CI-SH-AVL
55
+# PLEASE KEEP THIS GROUP OF FILES IN SYNC AT ALL TIMES:
@@ -38,7 +38,7 @@
3838
-DDOWNLOAD_CATCH=ON
3939
-DDOWNLOAD_EIGEN=ON
4040
-DCMAKE_CXX_STANDARD=17
41-
+ -DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT"
41+
+ -DCMAKE_CXX_FLAGS="-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT ${{runner.os == 'Windows' && '/GR /EHsc' || ''}}"
4242
-DPYBIND11_INTERNALS_VERSION=10000000
4343
"-DPYBIND11_TEST_OVERRIDE=test_call_policies.cpp;test_gil_scoped.cpp;test_thread.cpp"
4444
${{ matrix.args }}

0 commit comments

Comments
 (0)