Additional mock_caster testing for global & unnamed namespaces.

Author: rwgk

tests/test_make_caster_adl.cpp

@@ -1,16 +1,39 @@
-#include "pybind11_tests.h"
-
 // adl = Argument Dependent Lookup
 
-namespace adl_mock {
+#include "pybind11_tests.h"
+
+namespace have_a_ns {
 struct type_mock {};
 struct mock_caster {
     static int num() { return 101; }
 };
 mock_caster pybind11_select_caster(type_mock *);
-} // namespace adl_mock
+} // namespace have_a_ns
+
+// namespace global {
+struct global_ns_type_mock {};
+struct global_ns_mock_caster {
+    static int num() { return 202; }
+};
+global_ns_mock_caster pybind11_select_caster(global_ns_type_mock *);
+// } // namespace global
+
+namespace {
+struct unnamed_ns_type_mock {};
+struct unnamed_ns_mock_caster {
+    static int num() { return 303; }
+};
+#if defined(__GNUC__)
+#    pragma GCC diagnostic push
+#    pragma GCC diagnostic ignored "-Wunneeded-internal-declaration"
+#endif
+unnamed_ns_mock_caster pybind11_select_caster(unnamed_ns_type_mock *);
+#if defined(__GNUC__)
+#    pragma GCC diagnostic pop
+#endif
+} // namespace
 
-namespace adl_mrc { // minimal real caster
+namespace mrc_ns { // minimal real caster
 
 struct type_mrc {
     int value = -9999;
@@ -31,7 +54,7 @@ struct minimal_real_caster {
     // NOLINTNEXTLINE(google-explicit-constructor)
     operator type_mrc const &() {
         static type_mrc obj;
-        obj.value = 303;
+        obj.value = 404;
         return obj;
     }
 
@@ -43,15 +66,17 @@ struct minimal_real_caster {
 
 minimal_real_caster pybind11_select_caster(type_mrc *);
 
-} // namespace adl_mrc
+} // namespace mrc_ns
 
 TEST_SUBMODULE(make_caster_adl, m) {
-    m.def("num_mock", []() { return py::detail::make_caster<adl_mock::type_mock>::num(); });
+    m.def("have_a_ns_num", []() { return py::detail::make_caster<have_a_ns::type_mock>::num(); });
+    m.def("global_ns_num", []() { return py::detail::make_caster<global_ns_type_mock>::num(); });
+    m.def("unnamed_ns_num", []() { return py::detail::make_caster<unnamed_ns_type_mock>::num(); });
 
-    m.def("obj_mrc_return", []() {
-        adl_mrc::type_mrc obj;
-        obj.value = 404;
+    m.def("mrc_return", []() {
+        mrc_ns::type_mrc obj;
+        obj.value = 505;
         return obj;
     });
-    m.def("obj_mrc_arg", [](adl_mrc::type_mrc const &obj) { return obj.value + 2000; });
+    m.def("mrc_arg", [](mrc_ns::type_mrc const &obj) { return obj.value + 2000; });
 }

tests/test_make_caster_adl.py

@@ -4,13 +4,15 @@
 from pybind11_tests import make_caster_adl as m
 
 
-def test_mock_caster():
-    assert m.num_mock() == 101
+def test_mock_casters():
+    assert m.have_a_ns_num() == 101
+    assert m.global_ns_num() == 202
+    assert m.unnamed_ns_num() == 303
 
 
 def test_minimal_real_caster():
-    assert m.obj_mrc_return() == 1404
-    assert m.obj_mrc_arg(u"ignored") == 2303
+    assert m.mrc_return() == 1505
+    assert m.mrc_arg(u"ignored") == 2404
     with pytest.raises(TypeError) as excinfo:
-        m.obj_mrc_arg(None)
-    assert "(arg0: adl_mrc::type_mrc) -> int" in str(excinfo.value)
+        m.mrc_arg(None)
+    assert "(arg0: mrc_ns::type_mrc) -> int" in str(excinfo.value)