holder_construct: unsigned char -> bool

Author: jagerman

include/pybind11/cast.h

@@ -229,13 +229,13 @@ struct value_and_holder {
     bool holder_constructed() const {
         return inst->simple_layout
             ? inst->simple_holder_constructed
-            : (bool) inst->nonsimple.holder_constructed[index];
+            : inst->nonsimple.holder_constructed[index];
     }
     void set_holder_constructed() {
         if (inst->simple_layout)
             inst->simple_holder_constructed = true;
         else
-            inst->nonsimple.holder_constructed[index] = 1;
+            inst->nonsimple.holder_constructed[index] = true;
     }
 };
 
@@ -350,7 +350,7 @@ PYBIND11_NOINLINE inline void instance::allocate_layout() {
             space += t->holder_size_in_ptrs; // holder instance
         }
         size_t flags_at = space;
-        space += size_in_ptrs(n_types); // holder constructed flags
+        space += size_in_ptrs(n_types * sizeof(bool)); // holder constructed flags
 
         // Allocate space for flags, values, and holders, and initialize it to 0 (flags and values,
         // in particular, need to be 0).  Use Python's memory allocation functions: in Python 3.6
@@ -365,7 +365,7 @@ PYBIND11_NOINLINE inline void instance::allocate_layout() {
         if (!nonsimple.values_and_holders) throw std::bad_alloc();
         std::memset(nonsimple.values_and_holders, 0, space * sizeof(void *));
 #endif
-        nonsimple.holder_constructed = reinterpret_cast<unsigned char *>(&nonsimple.values_and_holders[flags_at]);
+        nonsimple.holder_constructed = reinterpret_cast<bool *>(&nonsimple.values_and_holders[flags_at]);
     }
     owned = true;
 }

include/pybind11/common.h

@@ -375,7 +375,7 @@ struct instance {
         void *simple_value_holder[1 + instance_simple_holder_in_ptrs()];
         struct {
             void **values_and_holders;
-            unsigned char *holder_constructed;
+            bool *holder_constructed;
         } nonsimple;
     };
     /// Weak references (needed for keep alive):
@@ -398,7 +398,7 @@ struct instance {
      * pointer to allocated space of the required space to hold a a sequence of value pointers and
      * holders followed by a set of holder-constructed flags (1 byte each), i.e.
      * [val1*][holder1][val2*][holder2]...[bb...]  where each [block] is rounded up to a multiple of
-     * `sizeof(void *)`.  `nonsimple.holders_constructed` is, for convenience, a pointer to the
+     * `sizeof(void *)`.  `nonsimple.holder_constructed` is, for convenience, a pointer to the
      * beginning of the [bb...] block (but not independently allocated).
      */
     bool simple_layout : 1;