From fef8402e0a8e681d3aae14bd8fad2710a1d4ceaa Mon Sep 17 00:00:00 2001 From: Anton Driesse Date: Wed, 18 Dec 2019 15:50:33 +0100 Subject: [PATCH 1/3] Clarification of parameter names vs source. --- pvlib/temperature.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pvlib/temperature.py b/pvlib/temperature.py index fed5cdca89..645ec51e06 100644 --- a/pvlib/temperature.py +++ b/pvlib/temperature.py @@ -307,6 +307,10 @@ def faiman(poa_global, temp_air, wind_speed=1.0, u0=25.0, u1=6.84): Notes ----- + Faiman [1] uses the parameter names U'0 and U'1 in equation 5, which + is the equation referred to as the Faiman model. In IEC-61853 and in + this function the prime is dropped from the parameter names. + All arguments may be scalars or vectors. If multiple arguments are vectors they must be the same length. From 12766f5e4043f34385cc64cbf5d3fd3c4e0eee59 Mon Sep 17 00:00:00 2001 From: Anton Driesse Date: Wed, 18 Dec 2019 21:55:39 +0100 Subject: [PATCH 2/3] Accept Cliff's suggestion. Co-Authored-By: Cliff Hansen --- pvlib/temperature.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/temperature.py b/pvlib/temperature.py index 645ec51e06..58b68ae95f 100644 --- a/pvlib/temperature.py +++ b/pvlib/temperature.py @@ -307,7 +307,7 @@ def faiman(poa_global, temp_air, wind_speed=1.0, u0=25.0, u1=6.84): Notes ----- - Faiman [1] uses the parameter names U'0 and U'1 in equation 5, which + Faiman [1] uses the parameter names U'_0 and U'_1 in equation 5 of [1]_, which is the equation referred to as the Faiman model. In IEC-61853 and in this function the prime is dropped from the parameter names. From 4163ca71e9e7c6bd8b9be441f24c9d41aa0d6d68 Mon Sep 17 00:00:00 2001 From: Anton Driesse Date: Thu, 19 Dec 2019 10:01:52 +0100 Subject: [PATCH 3/3] Please stickler and further clarify the clarification. --- pvlib/temperature.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvlib/temperature.py b/pvlib/temperature.py index 58b68ae95f..8de0a15872 100644 --- a/pvlib/temperature.py +++ b/pvlib/temperature.py @@ -307,9 +307,9 @@ def faiman(poa_global, temp_air, wind_speed=1.0, u0=25.0, u1=6.84): Notes ----- - Faiman [1] uses the parameter names U'_0 and U'_1 in equation 5 of [1]_, which - is the equation referred to as the Faiman model. In IEC-61853 and in - this function the prime is dropped from the parameter names. + Faiman uses the parameter names U'_0 and U'_1 in equation 5 of [1]_, which + is the equation referred to as the Faiman model. In IEC-61853 and also in + this function the primes (') are omitted from the parameter names. All arguments may be scalars or vectors. If multiple arguments are vectors they must be the same length.